Closed Bug 283509 Opened 16 years ago Closed 16 years ago

OOM crasher [@ mozEnglishWordUtils::FromRootForm]

Categories

(Core :: Spelling checker, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: timeless, Assigned: dewildt)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(1 obsolete file)

note that cleanup for this case needs to properly release the partially
constructed array.
The array is not released in other error situations. (For example, if result of
rv is not NS_OK inside the switch, is that ok?)
Who should do sr?
Assignee: mscott → dewildt
Status: NEW → ASSIGNED
Attachment #176063 - Flags: review?(timeless)
Attachment #176063 - Attachment description: This patch cleanup the allocated array if the loop is ended with an error → This patch cleanup the array inside the for loop and returns an error
Attachment #176063 - Flags: superreview?(mscott)
Attachment #176063 - Flags: review?(timeless)
Attachment #176063 - Flags: review+
Attachment #176063 - Flags: superreview?(mscott) → superreview+
Attachment #176063 - Flags: approval1.8b3?
Comment on attachment 176063 [details] [diff] [review]
This patch cleanup the array inside the for loop and returns an error

a=chofmann
Attachment #176063 - Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 176063 [details] [diff] [review]
This patch cleanup the array inside the for loop and returns an error

mozilla/extensions/spellcheck/src/mozEnglishWordUtils.cpp	1.8
Attachment #176063 - Attachment is obsolete: true
Daniel: Anything left here or can this bug be resolved as FIXED?
This landed, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
"Verified" FIXED by checking to make sure this landed in LXR.  (I checked
Talkback reports, too, of course, but as this was a precautionary fix, it wasn't
too useful.)
Status: RESOLVED → VERIFIED
Crash Signature: [@ mozEnglishWordUtils::FromRootForm]
You need to log in before you can comment on or make changes to this bug.