Closed Bug 283516 Opened 20 years ago Closed 15 years ago

OOM crash [@ NSString::createNewUnicodeBuffer]

Categories

(Core Graveyard :: Embedding: Mac, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: jaas)

References

()

Details

(Keywords: crash, Whiteboard: [ccbr])

Crash Data

Attachments

(1 file)

1.28 KB, patch
stuart.morgan+bugzilla
: review+
Details | Diff | Splinter Review
please handle oom :)
This code is now part of the spellchecker:

http://hg.mozilla.org/mozilla-central/annotate/37d1aab5e078/extensions/spellcheck/osxspell/src/mozOSXSpell.mm#l296

(there may also be a copy in a Camino repo somewhere)

I don't know objc, but line 301 followed by line 303 is scary by C standards...
Group: core-security
Flags: blocking1.9.2?
Hardware: PowerPC → All
Whiteboard: [ccbr]
osxspell has no 1.9.2 consumers at this time, blocking1.9.2-
Flags: blocking1.9.2? → blocking1.9.2-
Attached patch fix v1.0Splinter Review
Basic fix, I didn't fully audit consumers handling NULL from this method.
Assignee: ccarlen → joshmoz
Attachment #390074 - Flags: review?(stuart.morgan+bugzilla)
Comment on attachment 390074 [details] [diff] [review]
fix v1.0

r=smorgan
Attachment #390074 - Flags: review?(stuart.morgan+bugzilla) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/db8f89d7d03d
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Crash Signature: [@ NSString::createNewUnicodeBuffer]
Group: core-security
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: