283545 - OOM crash [@ nsFTPDirListingConv::OnDataAvailable]

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[timeless]

checking only some allocations isn't enough :)

Comment 1

[Bastiaan Jacques]

Attachment: fix

Comment 2

[Bastiaan Jacques]

Attachment: better fix

Comment 3

[Bastiaan Jacques]

Attachment: even better fix

nsCString -> nsCAutoString

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

why not use nsAutoArrayPtr<char> and new char[...]? That way, you can avoid the
goto, and just return.

Comment 5

[Bastiaan Jacques]

Attachment: address comment

Good idea.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 187799 [details] [diff] [review]
address comment

	 buffer = ToNewCString(mBuffer);

oh... I didn't realize that buffer gets a new value... you are now mismatching
allocators

Comment 7

[Bastiaan Jacques]

Attachment: address comments

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 187846 [details] [diff] [review]
address comments

+	 nsAutoArrayPtr<char> tmpBuffer (new char[mBuffer.Length()+1]);

I can't figure out why you didn't just reuse buffer here... or does:
  buffer = new char[...];
not work?

I think I wouldn't have removed the blank line here:
     rv = NS_NewCStringInputStream(getter_AddRefs(inputData), indexFormat);
-    if (NS_FAILED(rv)) return rv;
-

Comment 9

[Bastiaan Jacques]

Attachment: address comments

(In reply to comment #8)
> (From update of attachment 187846 [details] [diff] [review] [edit])
> +	 nsAutoArrayPtr<char> tmpBuffer (new char[mBuffer.Length()+1]);
> 
> I can't figure out why you didn't just reuse buffer here... or does:
>   buffer = new char[...];
> not work?
It does, but I assumed it didn't, because |nsAutoArrayPtr<char> buffer = new
char[..];| throws a compiler error. I've changed the code to do what you
described, though.

> I think I wouldn't have removed the blank line here:
>      rv = NS_NewCStringInputStream(getter_AddRefs(inputData), indexFormat);
> -    if (NS_FAILED(rv)) return rv;
> -
done.

Comment 10

[Bastiaan Jacques]

Checked in by timeless (2005-07-08 12:40).