OOM crash [@ nsGopherDirListingConv::OnDataAvailable]

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: timeless, Assigned: Andrew Schultz)

Tracking

({crash})

Trunk
x86
Windows XP
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
allocations need to be checked and the proper deallocators should be used
(Assignee)

Comment 1

14 years ago
Created attachment 175696 [details] [diff] [review]
check allocations, free them properly
Assignee: darin → ajschult
Status: NEW → ASSIGNED
Attachment #175696 - Flags: superreview?(darin)
Attachment #175696 - Flags: review?(cbiesinger)

Updated

14 years ago
Attachment #175696 - Flags: superreview?(darin) → superreview+
Comment on attachment 175696 [details] [diff] [review]
check allocations, free them properly

I'm not sure that DigestBufferLines is doing error handling correctly, but at
least this should prevent the crash.

(I'd think that ideally, ODA would cancel the channel with
NS_ERROR_OUT_OF_MEMORY in this case)
Attachment #175696 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 3

14 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsGopherDirListingConv::OnDataAvailable]
You need to log in before you can comment on or make changes to this bug.