283628 - Firefox .exe file reports incorrect version info

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Michael Ward]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1

After installing Firefox 1.0.1, the version information for firefox.exe in
Windows Explorer still reports it the File Version as 1.0.0.0. and the product
version is reported as 1.7.5: 2004110711

Reproducible: Always

Steps to Reproduce:
1. Using Windows Explorer, browse to your firefox 1.0.1 installation folder.
2. Right click on firefox.exe and choose properties from the menu.
3. In the resultant dilaog, click on the version tab.
4. Read "File Version" or click Product Version on the list and read the value

Actual Results:  
Wrong version information.

Expected Results:  
File Version should read 1.0.1.0
Product version should read(?): 1.7.6: 20050223

Comment 1

[Jo Hermans]

*** Bug 283652 has been marked as a duplicate of this bug. ***

Comment 2

[Chase Phillips]

Attachment: Bump internal file versions for browser and mail

Still need to find where 1.7.5 / 2004110711 is coming from.  Not sure yet.

Comment 3

[Chase Phillips]

Comment on attachment 175585 [details] [diff] [review]
Bump internal file versions for browser and mail

release-checklist.html has been updated to include these files in the list of
required version bumps for the apps.  Should rebuild soon.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 175585 [details] [diff] [review]
Bump internal file versions for browser and mail

r=dbaron, but please file a bug on getting this automated...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Although I guess it could also be part of bug 283218 if you comment there.)

Comment 6

[Chase Phillips]

(In reply to comment #0)
> After installing Firefox 1.0.1, the version information for firefox.exe in
> Windows Explorer still reports it the File Version as 1.0.0.0. and the product
> version is reported as 1.7.5: 2004110711

Testing here we confirm the file version is incorrect.  When we look at the
product version, though, it reports as 1.7.6: 2005...  I wonder what's different
between the installations.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 175585 [details] [diff] [review]
Bump internal file versions for browser and mail

a=dveditz

Is that copyright correct? The source is tri-licensed, but the binary is
released only under one.

Comment 8

[Chase Phillips]

Comment on attachment 175585 [details] [diff] [review]
Bump internal file versions for browser and mail

Landed this on aviary-1.0.1 branch.

Checking in browser/app/module.ver;
/cvsroot/mozilla/browser/app/module.ver,v  <--	module.ver
new revision: 1.9.4.5.2.1; previous revision: 1.9.4.5
done
Checking in mail/app/module.ver;
/cvsroot/mozilla/mail/app/module.ver,v	<--  module.ver
new revision: 1.4.2.3.2.5.2.1; previous revision: 1.4.2.3.2.5
done

Comment 9

[Chase Phillips]

When we verify that both the app version and product version are correct in a
newly spun build (say post drivers meeting), we should set fixed-aviary1.0.1.  I
don't think we should set it before then.

Comment 10

[Michael Ward]

(In reply to comment #6)
> Testing here we confirm the file version is incorrect.  When we look at the
> product version, though, it reports as 1.7.6: 2005...  I wonder what's different
> between the installations.

Confirming the same results with my home installation. It's not possible for me
to verify my work installation until Monday morning.

Comment 11

[Michael Ward]

(In reply to comment #10)
> Confirming the same results with my home installation. It's not possible for me
> to verify my work installation until Monday morning.

Re-installed and verified that the product version is in fact correct, but the
file version is incorrect.

Comment 12

[Chase Phillips]

This was fixed for 1.0.1.  Retroactively marking as such.