283647 - parser/htmlparser/src/nsExpatDriver.cpp lacs include for expat.h

Status: RESOLVED INVALID

(SeaMonkey :: General, defect)

Description

[J.O. Aho]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225

When trying to compile Mozilla 1.8b+ the whole halts at
parser/htmlparser/src/nsExpatDriver.cpp as it lacks a include to
parser/expat/lib/expat.h when compiling gtk+ with xft.

Reproducible: Always

Steps to Reproduce:
1. configure with --enable-toolkit-gtk --enable-xft
2. make


Actual Results:  
Compile breaks in parser/htmlparser/src/

Expected Results:  
As it did in Mozilla 1.8aX, full compile.

Adding a include line parser/htmlparser/src/nsExpatDriver.cpp to include
parser/expat/lib/expat.h fixes the whole problem.

Comment 1

[Andrew Schultz]

nsExpatDriver.cpp includes nsExpatDriver.h, which include expat.h
http://lxr.mozilla.org/mozilla/source/parser/htmlparser/src/nsExpatDriver.cpp#38
http://lxr.mozilla.org/mozilla/source/parser/htmlparser/src/nsExpatDriver.h#42

Comment 2

[J.O. Aho]

Okey, didn't look that much on the other files in the direcotry, just looked at
the file that was tried to be compiled.

Looking at the nsExpatDriver.h, shows that 

#include "expat_config.h"
#include "expat.h"

My a bit limited skills in C says that this will fail, as there aren't any such
files in the directory, while an includes

#include "../../expat/expat_config.h"
#include "../../expat/lib/expat.h"

would make it compile better.

Comment 3

[Andrew Schultz]

the compile line include "-I../../../dist/include/expat", which should contain
both include files.

did you make distclean after changing build options?

Comment 4

[J.O. Aho]

I'm using the Gentoo portage system, it deletes everything in the build
directory and reinstalls the clean source before starting to compile.

That "-I../../../dist/include/expat", shouldn't that be in a Makefile ?
greping don't find that string at all in the Makefile in parser/htmlparser/src/
nor in the Makefile/s closer to the root.

Comment 5

[Andrew Schultz]

ah.  well, it sounds like a Gentoo problem, then as things are working fine for
everyone else (and this code hasn't change in a long time)

this is all it should take:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/parser/htmlparser/src/Makefile.in&mark=61#61

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yep.  Please file a bug on gentoo on their packages not compiling... The
mozilla.org source compiles fine.