283660 - The new preferences window can't be closed on OS X (and doesn't have a collapse toolbar button)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Asaf Romano (gone)]

Well, escape does work, but we should enable the [x] button...

Comment 1

[Asaf Romano (gone)]

Attachment: patch for the close button thingy

..the collapse toolbar button (still) doesn't work (adding chromeclass-toolbar
alone doesn't help), I'll look into this later today.

Comment 2

[Asaf Romano (gone)]

Attachment: complete fix

sigh

Comment 3

[Asaf Romano (gone)]

Note: the noraml rules don't work becuase they're applied to the a window
element (and not to a <prefwindow>)

Comment 4

[Asaf Romano (gone)]

Comment on attachment 175584 [details] [diff] [review]
complete fix

err, wrong diff

Comment 5

[Asaf Romano (gone)]

Attachment: complete fix

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 175591 [details] [diff] [review]
complete fix

I'd much rather have Ben review this, I'm sure he'll be whacking regressions
soon.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 175591 [details] [diff] [review]
complete fix

ok

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 175591 [details] [diff] [review]
complete fix

r=[e-mail]

Comment 9

[Asaf Romano (gone)]

Checking in browser//base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.396; previous revision: 1.395
done
Checking in toolkit//content/xul.css;
/cvsroot/mozilla/toolkit/content/xul.css,v  <--  xul.css
new revision: 1.54; previous revision: 1.53
done
Checking in toolkit//content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.7; previous revision: 1.6
done

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change