283678 - Serif / Sans-serif pref ui doesn't work anymore

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Asaf Romano (gone)]

That's becuase the new pref code has overwritten the changes from bug 95227.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

What do I need to change?

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Comment on attachment 175720 [details] [diff] [review]
patch


>Index: components/preferences/fonts.js
>===================================================================
...
>       if (!preference) {
>         preference = document.createElement("preference");
>         var name = prefs[i].format.replace(/%LANG%/, aLanguageGroup);
>         preference.id = name;
>-        preferences.appendChild(preference);
>         preference.name = name;
>         preference.type = prefs[i].type;
>+        preferences.appendChild(preference);
>       }

(This change should fix bug Bug 283869, not sure).

Comment 4

[Asaf Romano (gone)]

Attachment: font dialog regressions - combined patch

(this one, bug 283869, bug 283945)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 175760 [details] [diff] [review]
font dialog regressions - combined patch 

>         var name = prefs[i].format.replace(/%LANG%/, aLanguageGroup);
>         preference.id = name;
>-        preferences.appendChild(preference);
>         preference.name = name;
>         preference.type = prefs[i].type;
>+        preferences.appendChild(preference);

Why did you do this? How can this work? You can't access the XBL properties on
the preference element until after it has been inserted into the document...

Comment 6

[Asaf Romano (gone)]

well, this was working...(In reply to comment #5)
> (From update of attachment 175760 [details] [diff] [review] [edit])
> >         var name = prefs[i].format.replace(/%LANG%/, aLanguageGroup);
> >         preference.id = name;
> >-        preferences.appendChild(preference);
> >         preference.name = name;
> >         preference.type = prefs[i].type;
> >+        preferences.appendChild(preference);
> 
> Why did you do this?

Apparently, without applying the type/name to the |preference| binding before
it's initialized, it (the binding) doesn't behave properly (i.e. bug 283869).

> How can this work? You can't access the XBL properties on
> the preference element until after it has been inserted into the document...

Although it was working... I'll change the type/name sets to |setAttribute| once
i get home.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Curious. Yes, change to setAttribute to be on the safe side, then r=[e-mail]

Comment 8

[Asaf Romano (gone)]

Attachment: font dialog regressions - combined patch

marking r= based on comment 7

Comment 9

[Asaf Romano (gone)]

Checking in content.js;
/cvsroot/mozilla/browser/components/preferences/content.js,v  <--  content.js
new revision: 1.7; previous revision: 1.6
done
Checking in content.xul;
/cvsroot/mozilla/browser/components/preferences/content.xul,v  <--  content.xul
new revision: 1.4; previous revision: 1.3
done
Checking in fontbuilder.js;
/cvsroot/mozilla/browser/components/preferences/fontbuilder.js,v  <-- 
fontbuilder.js
new revision: 1.3; previous revision: 1.2
done
Checking in fonts.js;
/cvsroot/mozilla/browser/components/preferences/fonts.js,v  <--  fonts.js
new revision: 1.3; previous revision: 1.2
done
Checking in fonts.xul;
/cvsroot/mozilla/browser/components/preferences/fonts.xul,v  <--  fonts.xul
new revision: 1.3; previous revision: 1.2
done

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change