283693 - crash dragging messages to other folders [nsNativeDragTarget::ProcessDrag]

Status: RESOLVED DUPLICATE of bug 125386

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

I'm pretty sure this is a pretty recent regression.

We now crash if you try to drag a message from one folder to another.

the current drag session is NULL because the drag service says we aren't doing a
drag anymore...

Here's the stack:

nsBaseDragService::GetCurrentSession(nsBaseDragService * const 0x01c98118,
nsIDragSession * * 0x0011e4a4) line 219
nsNativeDragTarget::ProcessDrag(IDataObject * 0x00000000, unsigned int 1401,
unsigned long 1, _POINTL {...}, unsigned long * 0x0011e624) line 221 + 56 bytes
nsNativeDragTarget::DragOver(nsNativeDragTarget * const 0x02e65670, unsigned
long 1, _POINTL {...}, unsigned long * 0x0011e624) line 288
OLE32! 775f8ede()
OLE32! 775f90c8()
OLE32! 775cfbdf()
OLE32! 775d0038()
nsDragService::StartInvokingDragSession(nsDragService * const 0x01c98118,
IDataObject * 0x032b89b8, unsigned int 3) line 176 + 25 bytes
nsDragService::InvokeDragSession(nsDragService * const 0x01c98118, nsIDOMNode *
0x02bcdb4c, nsISupportsArray * 0x032d4f98, nsIScriptableRegion * 0x0328a1b0,
unsigned int 3) line 144 + 25 bytes
 
we crash here:

  // Set the current action into the Gecko specific type
  nsCOMPtr<nsIDragSession> currSession;
  mDragService->GetCurrentSession ( getter_AddRefs(currSession) );
  currSession->SetDragAction(geckoAction);

dereferencing currSession

Comment 1

[Scott MacGregor]

This regression was caused by Bug #125386. Backing out that view manager changes
makes drag and drop work again without crashing. Roc can you please take a look
at this? (It's probably the weekend already in New Zealand). 

Comment 2

[Scott MacGregor]

Attachment: patch that fixes the crash

I had to make a few tweaks to Boris's suggested fix to get it to compile.

Comment 3

[Matthias Versen [:Matti]]

dupe of bug 283478 ?

Comment 4

[timeless]

*** This bug has been marked as a duplicate of 125386 ***