Closed Bug 283701 Opened 19 years ago Closed 5 years ago

Improve check for calling nsXBLBinding::MarkForDeath

Categories

(Core :: XBL, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bryner, Unassigned)

References

Details

nsBindingManager::FlushSkinBindings enumerates the binding table with
MarkForDeath, which calls binding->MarkForDeath() on each binding where the
binding document URI's "path" component begins with "/skin".  This is not 100%
correct, for example, it would flush http://foo.com/skin/binding.xml.  We should
use the chrome registry to tell us that this is a chrome skin URI.
bsmedberg, the chrome registry already has methods for this (the "allow scripts
for skin" stuff).  Can you expose reasonable hooks that I could call into here?
 Perhaps inSkinPackage(chromeURI) or something?
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla1.8beta2
Depends on: 306109
Depends on: 306110
This is to fix the case when two skins bindings using the same URI?

I guess dbaron's patch to make image switching work properly would have helped.
> This is to fix the case when two skins bindings using the same URI?

I don't actually know what this code is doing....
QA Contact: ian → xbl
Assignee: bzbarsky → nobody
Priority: P3 → --
Target Milestone: mozilla1.8beta2 → ---

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.