283701 - Improve check for calling nsXBLBinding::MarkForDeath

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Description

[Brian Ryner (not reading)]

nsBindingManager::FlushSkinBindings enumerates the binding table with
MarkForDeath, which calls binding->MarkForDeath() on each binding where the
binding document URI's "path" component begins with "/skin".  This is not 100%
correct, for example, it would flush http://foo.com/skin/binding.xml.  We should
use the chrome registry to tell us that this is a chrome skin URI.

Comment 1

[Boris Zbarsky [:bzbarsky]]

bsmedberg, the chrome registry already has methods for this (the "allow scripts
for skin" stuff).  Can you expose reasonable hooks that I could call into here?
 Perhaps inSkinPackage(chromeURI) or something?

Comment 2

[[e-mail]]

This is to fix the case when two skins bindings using the same URI?

I guess dbaron's patch to make image switching work properly would have helped.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> This is to fix the case when two skins bindings using the same URI?

I don't actually know what this code is doing....

Comment 4

[Boris Zbarsky [:bzbarsky]]

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.