283712 - Build process of the windows mk-MK translation of Firefox-1.0.1 broken (+patches)

Status: RESOLVED FIXED

(Mozilla Localizations :: mk / Macedonian, defect)

Description

[Damjan Georgievski]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-mk-MK
The build process fails when converting the installer file
./browser/locales/mk-MK/installer/installer.inc form utf-8 to cp1251.

Reproducible: Always

Comment 1

[Damjan Georgievski]

Attachment: patch for ./browser/locales/mk-MK/installer/installer.inc

This is a one character patch  that will solve the problem with the windows
build http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-mk-MK

Comment 2

[Damjan Georgievski]

Attachment: patch for ./browser/locales/mk-MK/defines.inc

This is a patch to correct the MOZ_LANGPACK_CREATOR value in
./browser/locales/mk-MK/defines.inc as requested by Zbigniew Braniecki
(gandalf) here https://bugzilla.mozilla.org/show_bug.cgi?id=276345#c20

Since I could't request approval in that bug I'm resubmiting it here.

Comment 3

[Damjan Georgievski]

Attachment: patch for ./toolkit/locales/mk-MK/chrome/global/printdialog.properties

Patches an error in printdialog.properties, extend=true shouldn't have been
translated.

Comment 4

[Chase Phillips]

Comment on attachment 175592 [details] [diff] [review]
patch for ./browser/locales/mk-MK/installer/installer.inc

This is needed to get mk-MK builds on Windows.

Comment 5

[Chase Phillips]

Comment on attachment 175594 [details] [diff] [review]
patch for ./browser/locales/mk-MK/defines.inc

a=chase

This patch is obviously the right thing to do.	Let's get it in soon.

Comment 6

[Chase Phillips]

Comment on attachment 175595 [details] [diff] [review]
patch for ./toolkit/locales/mk-MK/chrome/global/printdialog.properties

I'd like to approve this but I need gandalf/pike's counsel on the issue.  I
suppose until it's in our mk-MK builds won't be able to print.

Comment 7

[Chase Phillips]

-> Confirmed.

Comment 8

[Chase Phillips]

Added a mk-MK bmo component.  Transferring this bug into it.

Comment 9

[Damjan Georgievski]

(In reply to comment #6)
> (From update of attachment 175595 [details] [diff] [review] [edit])
> I'd like to approve this but I need gandalf/pike's counsel on the issue.  I
> suppose until it's in our mk-MK builds won't be able to print.

Look at the comments in the file:
http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/mk-MK/chrome/global/printdialog.properties

Comment 10

[Damjan Georgievski]

Anyone commiting these patches, please don't forget the bookmark patch in bug
#281011. It's approved.

Comment 11

[Damjan Georgievski]

Patches commited to CVS. 
[my first CVS coommit to mizlla I hope its ok :)]