Closed Bug 283713 Opened 19 years ago Closed 19 years ago

preferences dialog gets progressively shorter when rapidly switching panels

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: bugzilla, Assigned: jaas)

References

Details

Attachments

(1 file, 1 obsolete file)

updated patch, v2
1.17 KB, patch
jaas
: review+
mconnor
: superreview+
Details | Diff | Splinter Review 
found using 2005022507-trunk on mac os x 10.3.8. thanks to Mano for pointing
this out on irc.

1. open Preferences dialog.

2. rapidly click btwn panels (via clicking the icons in the toolbar) --eg,
General and Privacy-- but it needs to be fast enough such that the dynamic
resizing doesn't finish drawing the dialog.

3. repeat step 2 several times and watch the height of the Preferences dialog.

results: you'll noticed that the height gets progressively shorter. in fact, if
you stop switching panels, you'll get into a state where the dialog is too short
to see to content and use.

workaround: closing and reopening the dialog resets it to a readble state.
Flags: blocking-aviary1.1?
Depends on: 274712
I can confirm for: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050227 Firefox/1.0+
This seems fine to me using "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b2) Gecko/20050228 Firefox/1.0+" I've tried it by basically opening
options and then holding the right arrow down to make it cycle very rapidly
through the panes. There was no change in height. I'm using a 2.8GHz P4, so I
don't know if it's just doing it too fast to make a difference or what. I will
try on my G4 400 Mac, which is MUCH slower and see if I can reporduce.
I see this as well on Windows XP, but only when animateFadeIn is enabled.

To confirm, it did show up on the Mac build, however, that makes sense since
animateFadeIn is on by default there. Likewise, it shows up on Windows when that
is enabled.
Attached patch hmm, fix? (obsolete) — — Splinter Review 
hacky solution.. since oldpane.contentHeight won't be used after the very first
time animate() is called; A real soultion would be to find out a better way to
get the currentHieght (of the contentBox only).
Attachment #176573 - Flags: review?(bugs)
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Comment on attachment 176573 [details] [diff] [review]
hmm, fix?

needs update
Attachment #176573 - Attachment is obsolete: true
Attachment #176573 - Flags: review?(bugs)
This is an updated version of Mano's patch, so it applies on the trunk. It
seems reasonable and works just fine.
Assignee: bugs → joshmoz
Status: NEW → ASSIGNED
Attachment #178809 - Flags: superreview?(mconnor)
Attachment #178809 - Flags: review+
Comment on attachment 178809 [details] [diff] [review]
updated patch, v2

>Index: toolkit/content/widgets/preferences.xml
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v
>retrieving revision 1.11
>diff -u -r1.11 preferences.xml
>--- toolkit/content/widgets/preferences.xml	23 Mar 2005 10:51:09 -0000	1.11
>+++ toolkit/content/widgets/preferences.xml	28 Mar 2005 04:49:48 -0000
>@@ -649,12 +649,14 @@
>         <parameter name="aNewPane"/>
>         <body>
>         <![CDATA[
>-          this._multiplier = aNewPane.contentHeight > aOldPane.contentHeight ? 1 : -1;
>-          var sizeDelta = Math.abs(aOldPane.contentHeight - aNewPane.contentHeight);
>+          // if we are already resizing, use currentHeight
>+          var oldHeight = this._currentHeight? this._currentHeight : aOldPane.contentHeight;

nit: space before ?
Attachment #178809 - Flags: superreview?(mconnor) → superreview+
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Thanks for driving this in, Josh :)
Target Milestone: --- → Firefox1.1
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: