283729 - Startup errors/warnings in JavaScript console (trunk)

Status: VERIFIED FIXED

Description

[Mike Cowperthwaite]

TB 1.0+0222, Win2K


Error: [Exception... "Component returned failure code: 0x8000ffff 
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff 
(NS_ERROR_UNEXPECTED)"  location: "JS frame :: file:///C:/Moz/TB/components/
nsDefaultCLH.js :: clh_handle :: line 81"  data: no]
Source File: file:///C:/Moz/TB/components/nsDefaultCLH.js
Line: 81

Error: redeclaration of const kMailToLength
Source File: chrome://communicator/content/nsContextMenu.js
Line: 12

Error: redeclaration of const SAVETYPE_COMPLETE_PAGE
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 245


These errors have been appearing for a while -- see bug 279657, which was filed 
under the Mac.
If they have any side effects, I dunno what those could be.

Comment 1

[Mike Cowperthwaite]

In TB 1.0+0327, the first (and presumably most serious) of the listed errors no 
longer appears.

Comment 2

[Scott MacGregor]

gandalf accidentally removed a bunch of core files for Thunderbird over the weekend.

Comment 3

[Zibi Braniecki [:gandalf][:zibi]]

Scott: It's not my fault. It has nothing to do with my patch.

Comment 4

[Scott MacGregor]

whoops I read this bug report wrong. 

Comment 5

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

All errors are gone now. Only a remaining js strict warning still appears:

Warning: reference to undefined property defaultServer.msgFolder
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 920

Comment 6

[Mike Cowperthwaite]

(In reply to comment #5)
> All errors are gone now. Only a remaining js strict warning still appears:
> 
> Warning: reference to undefined property defaultServer.msgFolder
> Source File: chrome://messenger/content/msgMail3PaneWindow.js
> Line: 920

I'm not even seeing that one! (0725, Win2K)  Maybe it's from an extension?

Comment 7

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Mike, I still see this strict warning with a todays cvs build. I've no
extensions installed within my profile. I downloaded an official nightly build
and found some more warnings. These are still part of mail source:

Warning: variable displayName hides argument
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 420, Column: 10
Source Code:
      var displayName = displayName.replace(/ +/g, " ");

Warning: variable emailAddress hides argument
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 944, Column: 6
Source Code:
  var emailAddress = addressNode.getTextAttribute("emailAddress");

Warning: variable folder hides argument
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2085, Column: 14
Source Code:
          var folder = GetLoadedMsgFolder();

Warning: reference to undefined property defaultServer.msgFolder
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 920

Reopening until we solved the remaining strict warnings.

Comment 8

[Mike Cowperthwaite]

With 0803, this one is back:
Error: Unknown namespace prefix 'html'.  Ruleset ignored due to bad selector.
Source File: chrome://messenger/skin/messageBody.css
Line: 55

But that's the only one I'm seeing.  (Win2K)

Comment 9

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Created attachment 195646 [details] [diff] [review]
Fix for all js warnings

Comment 10

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Created attachment 195656 [details] [diff] [review]
Patch without msgMail3PaneWindow.js changes

The warning within msgMail3PaneWindow.js will be fixed by the fix on bug
270743.

Comment 11

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Comment on attachment 195656 [details] [diff] [review]
Patch without msgMail3PaneWindow.js changes

The patch can be safely applied without any reported error to the 1.8 branch
version:

> patching file mail/base/content/msgHdrViewOverlay.js
> patching file mail/base/content/mailWindowOverlay.js

Comment 12

[Scott MacGregor]

Comment on attachment 195656 [details] [diff] [review]
Patch without msgMail3PaneWindow.js changes

please don't nominate th8ings like JS warning as blockers for the branch. The
trunk is fine for these bugs.

Comment 13

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

These are small changes of js code. Do we really need sr=? If not, this patch
could be checked-in on the trunk.

Comment 14

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Scott, can you give an advice how to handle the remaining steps to get my patch checked-in?

Comment 15

[Scott MacGregor]

Comment on attachment 195656 [details] [diff] [review]
Patch without msgMail3PaneWindow.js changes

sr'ing a patch i already reviewed.

Comment 16

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

2005-11-09 13:40	timeless%mozdev.org 	mozilla/ mail/ base/ content/ mailWindowOverlay.js 	1.105 	3/2

2005-11-09 13:40	timeless%mozdev.org 	mozilla/ mail/ base/ content/ msgHdrViewOverlay.js 	1.62 	4/4

Comment 17

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment 195656 [details] [diff] was never checked into 1.8 branch. The js warnings are still present in current builds. The code has changed a bit. It has to be adapted. I don't have any chance to do it for the next days. Seems that's also too late for Thunderbird 2. :(

Warning: variable displayName hides argument
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 409, Column: 10
Source Code:
      var displayName = displayName.replace(/ +/g, " ");

Warning: variable emailAddress hides argument
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 899, Column: 6
Source Code:
  var emailAddress = addressNode.getAttribute("emailAddress");

Comment 18

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Created attachment 258403 [details] [diff] [review]
Remove startup warnings for 1_8_branch

Comment 19

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Created attachment 258404 [details] [diff] [review]
[checked into the branch] Remove startup warnings for 1_8_branch

Scott, is it quiet possible to get this simple fix into Thunderbird 2? It will remove all the clutter from the Error Console when starting Thunderbird.

Comment 20

[Scott MacGregor]

Comment on attachment 258404 [details] [diff] [review]
[checked into the branch] Remove startup warnings for 1_8_branch

Please don't expect us to usually take JS warning fixes this late in the release cycle. I don't want to set a precedent. :)

This has been baking for over a year and we haven't tagged yet so I'm going to put it in.

Comment 21

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

No, I don't expect. ;) Thank you Scott.