Closed Bug 283741 Opened 20 years ago Closed 20 years ago

Javascript strict warning: trailing comma in nsSetDefaultBrowser.js

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox1.5

People

(Reporter: jason.barnabe, Assigned: jason.barnabe)

References

Details

Attachments

(1 file, 1 obsolete file)

patch [checked in]
1.12 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: file:///C:/PROGRA~1/MOZILL~1/components/nsSetDefaultBrowser.js
Line: 68
Source Code:
};

        Attachment #175618 -
        Flags: review?(mconnor)

        Attachment #175618 -
        Flags: review?(mconnor) → review+

    
    

    
  
Thanks. Can you also check it in? (I don't need sr for little patches like this,
do I?)

    
    

    
  
(I keep forgetting to cc the people I want to ask something of...)

> Thanks. Can you also check it in? (I don't need sr for little patches like this,
> do I?)

    
  
Flags: blocking-aviary1.1?

    
    

    
  
No SR is needed in browser and toolkit, review from a peer suffices.
Whiteboard: [checkin needed]

    
    

    
  
Checking in nsSetDefaultBrowser.js;
/cvsroot/mozilla/browser/components/shell/src/nsSetDefaultBrowser.js,v  <-- 
nsSetDefaultBrowser.js
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.1?
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.1

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Another warning [checked in] (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #179504 -
        Flags: review?(mconnor)

        Attachment #179504 -
        Flags: review?(mconnor) → review+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [checkin needed]

    
  
Flags: blocking-aviary1.1?
Flags: blocking-aviary1.1? → blocking-aviary1.1-

        Attachment #175618 -
        Attachment description: patch → patch [checked in]

        Attachment #179504 -
        Flags: approval-aviary1.1a2?

    
    

    
  
Comment on attachment 179504 [details] [diff] [review]
Another warning [checked in]

a=shaver

        Attachment #179504 -
        Flags: approval-aviary1.1a2? → approval-aviary1.1a2+

    
    

    
  
Gavin, when your patch will be checked in? 

    
    

    
  
Comment on attachment 179504 [details] [diff] [review]
Another warning [checked in]

mozilla/browser/components/shell/src/nsSetDefaultBrowser.js	1.7

        Attachment #179504 -
        Attachment is obsolete: true

        Attachment #179504 -
        Attachment description: Another warning → Another warning [checked in]
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]

    
    

    
  
v with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050621
Firefox/1.0+
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: