Closed Bug 283754 Opened 15 years ago Closed 6 years ago

Awkward phrasing in language selection dialog - "in order of preference" used twice

Categories

(Firefox :: Preferences, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: Waldo, Assigned: nikhiljohny)

References

()

Details

Attachments

(1 file, 1 obsolete file)

We should try to use different phrasing for these two strings, because it looks
really odd (especially because the strings are placed right next to each other).
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
Assignee: bugs → nobody
Hi, this seems to be a simple bug to fix. But i can't find the language options in the prefrences to test it out. Can someone help me with this, thanks
(In reply to Nikhil Johny from comment #2)
> Hi, this seems to be a simple bug to fix. But i can't find the language
> options in the prefrences to test it out. Can someone help me with this,
> thanks

Options / Preferences -> Content -> Languages
oops, sorry found it. What should i change the strings to? This is my second bug.
Unless you have a better idea, I think we can just get rid of the first "in order of preference".
Attached patch first patch (obsolete) — Splinter Review
Attachment #8380329 - Flags: review?(dao)
Comment on attachment 8380329 [details] [diff] [review]
first patch

On second thought, how about we let that sentence end with a colon ("... languages for displaying these web pages, in order of preference:") and completely get rid of the languages.customize.active.label string?

Either way, we need to rename languages.customize.prefLangDescript in order to notify maintainers of locales other than en-US that they need to make a similar change. I'd suggest languages.customize.description as the new name.
Attachment #8380329 - Flags: review?(dao) → review-
Attached patch second patchSplinter Review
I have removed the 'languages.customize.active.label' completely from languages.dtd and languages.xul. And have changed the 'languages.customize.prefLangDescript' to 'languages.customize.description' to notify the localizers. Let me know if there's something else.
Attachment #8380329 - Attachment is obsolete: true
Attachment #8380763 - Flags: review?(dao)
Comment on attachment 8380763 [details] [diff] [review]
second patch

Perfect, thanks!
Attachment #8380763 - Flags: review?(dao) → review+
Assignee: nobody → nikhiljohny
https://hg.mozilla.org/mozilla-central/rev/382ae10f777c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.