283754 - Awkward phrasing in language selection dialog - "in order of preference" used twice

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jeff Walden [:Waldo]]

We should try to use different phrasing for these two strings, because it looks
really odd (especially because the strings are placed right next to each other).

Comment 1

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change

Comment 2

[Nikhil Johny]

Hi, this seems to be a simple bug to fix. But i can't find the language options in the prefrences to test it out. Can someone help me with this, thanks

Comment 3

[Dão Gottwald [:dao]]

(In reply to Nikhil Johny from comment #2)
> Hi, this seems to be a simple bug to fix. But i can't find the language
> options in the prefrences to test it out. Can someone help me with this,
> thanks

Options / Preferences -> Content -> Languages

Comment 4

[Nikhil Johny]

oops, sorry found it. What should i change the strings to? This is my second bug.

Comment 5

[Dão Gottwald [:dao]]

Unless you have a better idea, I think we can just get rid of the first "in order of preference".

Comment 6

[Nikhil Johny]

Attachment: first patch

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8380329 [details] [diff] [review]
first patch

On second thought, how about we let that sentence end with a colon ("... languages for displaying these web pages, in order of preference:") and completely get rid of the languages.customize.active.label string?

Either way, we need to rename languages.customize.prefLangDescript in order to notify maintainers of locales other than en-US that they need to make a similar change. I'd suggest languages.customize.description as the new name.

Comment 8

[Nikhil Johny]

Attachment: second patch

I have removed the 'languages.customize.active.label' completely from languages.dtd and languages.xul. And have changed the 'languages.customize.prefLangDescript' to 'languages.customize.description' to notify the localizers. Let me know if there's something else.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8380763 [details] [diff] [review]
second patch

Perfect, thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/382ae10f777c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/382ae10f777c