283777 - Right arrow key after selecting autocomplete result no longer uses selected item

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Asa Dotzler [:asa]]

In html forms we used to be able to select an auto-complete item and hit the
right arrow and it would fill that item placing the caret at the end of that
word. Now hitting the right arrow dismisses autocomplete. IE's right arrow on
autocomplete does nothing. We used to be better and now we're either similar or
worse. It would be good to get this back to being better. Tested with 1.0.1 on
windows XP

Comment 1

[Dave Miller [:justdave]]

For the record, this worked in 1.0.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is fallout from bug 270697, I assume.

Comment 3

[Brendan Eich [:brendan]]

dveditz, do you want to take this?  Ben can certainly fix it, but you were last
to touch and may be best assignee.  Bryner would help too, I bet.

/be

Comment 4

[Daniel Veditz [:dveditz]]

Attachment: restore old right-arrow behavior

In the spirit of sheer nitpickiness the right-arrow is doing what it has always
done: close the popup and nothing more. The text was already filled in because
selecting an item did it.

This patch restores right-arrow functionality. left-arrow functionality is one
character different: in the past the caret would be one character before the
end, this patch puts it at the end like right-arrow instead. If left-arrow had
done something useful like put the caret at the beginning it might have been
worth trying to preserve, but for one character I think this is OK.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 175688 [details] [diff] [review]
restore old right-arrow behavior

Neil isn't a toolkit peer, and toolkit doesn't require SR.

One thought, is handleEnter really the right name still, now that we're not
just calling it on when pressing Enter?

Comment 6

[Jesse Ruderman]

*** Bug 284985 has been marked as a duplicate of this bug. ***

Comment 7

[Chase Phillips]

Comment on attachment 175688 [details] [diff] [review]
restore old right-arrow behavior

a=chase approved for landing on the trunk

Comment 8

[Chase Phillips]

Comment on attachment 175688 [details] [diff] [review]
restore old right-arrow behavior

approval-aviary1.0.3-, nominating for approval-aviary1.0.4

Comment 9

[Daniel Veditz [:dveditz]]

checked in to trunk

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> checked in to trunk
could this have caused bug 290172 ?

Comment 11

[Mark Mentovai]

HandleEnter is no good because in the location bar or search bar, Enter causes
the browser to immediately begin loading a new page.  This is bug 290172. 
Attachment 180740 [details] [diff] to that bug is a reimplementation of the fix for this bug. 
The only difference compared to the committed patch (attachment 175688 [details] [diff] [review]) is that
the left arrow moves the insertion point to one character before the end.  See
comment 4.  I experimented with having the left arrow key move the insertion
point to the beginning of the string, but I didn't like that in cases where
completeselectedindex is set.

This patch approximates the behavior of Firefox 1.0 as nearly as I am able to
discern.  The only difference seems to be that completeselectedindex seems to be
set for text fields in 1.0 and is not set for text fields on the trunk.  (It is
set for the location bar and search bar, though.)

Comment 12

[Mark Mentovai]

Attachment: Patch for AVIARY_1_0_1 branch

This is a fix for the 1.0.x branch using the same strategy that was used in bug
290172.  It restores the desired side arrow key behavior without making the
location bar unpleasant.  Since the bug is a regression from 1.0 in the 1.0.x
series, mconnor asked me to port that patch from the trunk.

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 180857 [details] [diff] [review]
Patch for AVIARY_1_0_1 branch

not sure if/when we'll have a 1.0.4, but this meets current criteria
(regression from a security fix) and is on trunk already.

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 175688 [details] [diff] [review]
restore old right-arrow behavior

Don't want this one

Comment 15

[Brendan Eich [:brendan]]

1.0.4 is not taking non-critical security fixes.

/be

Comment 16

[Jay Patel [:jay]]

dveditz:  Do we need an sr= before approving this for 1.0.5?

Comment 17

[Jay Patel [:jay]]

Let's get this on the Aviary branch... a=jay

Comment 18

[Mike Connor [:mconnor]]

landed attachment 180857 [details] [diff] [review] on the aviary1.0.1 branch