Closed Bug 283827 Opened 15 years ago Closed 15 years ago

When turn on IME and switch applications before fix characters, location bar doesn't accept any more character

Categories

(Core Graveyard :: Widget: Mac, defect, minor)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: katsuhiromihara, Assigned: katsuhiromihara)

Details

(Keywords: intl)

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050225
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050225

Original report:
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=4135

User can turn on IME even on location bar.
When user switch applications before fix
characters, location bar doesn't accept
any more characters.

Workaround is only close that window of
Mozilla Suite and reopen another window.


Reproducible: Always

Steps to Reproduce:
1. turn on IME on location bar
2. enter characters on location bar
3. translate characters, but doesn't fix
4. switch applications to other
5. switch applications to Mozilla Suite
6. enter characters on location bar
   (doesn't matter IME is on or off)
Actual Results:  
Location bar doesn't accept any more characters.

Expected Results:  
Location bar should accept more characters.
Attached patch patch (nsMacEventtHandler) (obsolete) — Splinter Review
Call FixTSMDocument() before deactivate window.

Ideally, we doesn't need to call FixTSMDocument(),
http://developer.apple.com/documentation/Carbon/Reference/Text_Services_Manager/tsm_refchap/function_group_2.html#//apple_ref/doc/uid/TP30000174/F01518

but Mozilla Suite can't handle next event correctly.
Attachment #175650 - Flags: superreview?(sfraser_bugs)
Attachment #175650 - Flags: review?(pinkerton)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

r=pink

are there any other places we should do this?
Attachment #175650 - Flags: review?(pinkerton) → review+
I don't find any other places.

I found a place that fix this bug, and just did this.
Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

peterv, would you sr this assuming the old sense of 'sr' still holds? sfraser
is on vacation and you may be the only active superreviewer with  some Mac
connection....
And, it'd be nice of you to take a look at bug 158859 as well.
Attachment #175650 - Flags: superreview?(sfraser_bugs) → superreview?(peterv)
Attachment #175650 - Flags: superreview?(peterv) → superreview?(sfraser_bugs)
Attachment #175650 - Flags: superreview?(sfraser_bugs) → superreview+
Please introduce someone who can commit a patch.
I don't have a CVS account.
Component: XP Apps: GUI Features → Widget: Mac
Product: Mozilla Application Suite → Core
Version: unspecified → Trunk
Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

the tree is currently frozen, so this patch would need approval before it could
be committed. the change is small and localized.
Attachment #175650 - Flags: approval1.8b2?
Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

a=asa
Attachment #175650 - Flags: approval1.8b2? → approval1.8b2+
Assignee: guifeatures → katsuhiromihara
Status: NEW → ASSIGNED
Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

mozilla/widget/src/mac/nsMacEventHandler.cpp	1.172
Attachment #175650 - Attachment is obsolete: true
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.