283851 - javascript strict warnings in nsBrowserContentHandler.js

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050226 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050226 Firefox/1.0+

http://lxr.mozilla.org/seamonkey/source/browser/components/nsBrowserContentHandler.js#172
and
http://lxr.mozilla.org/seamonkey/source/browser/components/nsBrowserContentHandler.js#306

Reproducible: Always

Steps to Reproduce:

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Those assignments are done on purpose, and the strict warnings are just there to
catch possible mistakes. They don't require fixing.

Comment 2

[Robert Strong (they/them - no direct email)]

I realize this and doing the following should allow for the assignment while
removing the warning.

Index: nsBrowserContentHandler.js
===================================================================
RCS file: /cvsroot/mozilla/browser/components/nsBrowserContentHandler.js,v
retrieving revision 1.4
diff -u -r1.4 nsBrowserContentHandler.js
--- nsBrowserContentHandler.js	19 Feb 2005 01:36:59 -0000	1.4
+++ nsBrowserContentHandler.js	26 Feb 2005 20:34:48 -0000
@@ -169,7 +169,7 @@
 
     try {
       var uriparam;
-      while (uriparam = cmdLine.handleFlagWithParam("new-window", false)) {
+      while ((uriparam = cmdLine.handleFlagWithParam("new-window", false))) {
         var uri = cmdLine.resolveURI(uriparam);
         openWindow(null, this.chromeURL, "_blank",
                    "chrome,dialog=no,all" + this.getFeatures(cmdLine),
@@ -303,7 +303,7 @@
 
     try {
       var ar;
-      while (ar = cmdLine.handleFlagWithParam("url", false)) {
+      while ((ar = cmdLine.handleFlagWithParam("url", false))) {
         urilist.push(cmdLine.resolveURI(ar));
       }
     }

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Ok, attach the patch, and ask for review from [e-mail].

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Not sure who should sr this one so any info in this regard would be welcome.
Thanks.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

No SR is needed in /browser.

Comment 6

[Asaf Romano (gone)]

Checking in nsBrowserContentHandler.js;
/cvsroot/mozilla/browser/components/nsBrowserContentHandler.js,v  <-- 
nsBrowserContentHandler.js
new revision: 1.6; previous revision: 1.5
done