283868 - cattable.h:1477: comparison is always true due to limited range of data type

Status: RESOLVED WONTFIX

(Core :: Spelling checker, defect)

Description

[Bastiaan Jacques]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225

Cosmetic bug.

/home/baafie/src/mozilla/extensions/spellcheck/src/cattable.h: In function
'PRUint8 GetCat(PRUnichar)':
/home/baafie/src/mozilla/extensions/spellcheck/src/cattable.h:1477: warning:
comparison is always true due to limited range of data type

Line 1477 is if((((PRUnichar)0xF900)<=u)&&(u<=((PRUnichar)0xFFFF))) {

The error is produced because (u<=((PRUnichar)0xFFFF)) is always true on when
neither WIN32 or XP_MAC are defined.

Reproducible: Always

Comment 1

[Bastiaan Jacques]

Attachment: preserve my sanity

Only do the extra check when we are on windows or mac.

Comment 2

[Scott MacGregor]

Comment on attachment 175671 [details] [diff] [review]
preserve my sanity

these files are direct copies of the myspell version in the open office.org
project. We periodically copy them from their repository back into ours to get
the latest and greatest stuff.

If you want to make changes to these files I suggest you submit them to the
Open office spell checker bug system and get them changed there.