283919 - Move BugAliasToID out of CGI.pl into Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

Here are the only places BugAliasToID is used:

Bugzilla/Bug.pm:  $bug_id = &::BugAliasToID($bug_id) if $bug_id !~
/^0*[1-9][0-9]*$/;
CGI.pl:sub BugAliasToID {

This tends to make me think that:

1) We don't use it where we should.
2) People ought to use Bug objects.

I have to investigate a bit to determine whether or not the function should be
removed entirely.

Comment 1

[Max Kanat-Alexander]

I investigated. BugAliasToID will just be eliminated. It has no use at this
point. I suppose we can add it back if we need it in the future.

It *seems* like it ought to be a useful function, but I think that everything
that needs to know about aliases is now using Bug objects (which is pretty much
as it should be).

Comment 2

[Max Kanat-Alexander]

Attachment: Very Simple: Refactor the one BugAliasToID call

Comment 3

[Max Kanat-Alexander]

Attachment: v1.1

Oh, the previous one had too-long of a line. Fixed. :-)

Comment 4

[Frédéric Buclin]

Comment on attachment 175701 [details] [diff] [review]
v1.1

ValidateBugID still uses BugAliasToID!

Comment 5

[Max Kanat-Alexander]

Darn. OK, I'll have to get a new patch up. :-)

Comment 6

[Max Kanat-Alexander]

Attachment: v2 (Move to Bugzilla::Bug)

OK, I feel more comfortable about this patch, anyhow. :-)

Comment 7

[Max Kanat-Alexander]

Attachment: v2.1

Fixed some bitrot that LpSolit pointed out on IRC.

Comment 8

[Frédéric Buclin]

Comment on attachment 176620 [details] [diff] [review]
v2.1

works fine! r=LpSolit

Comment 9

[Max Kanat-Alexander]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.233; previous revision: 1.232
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.63; previous revision: 1.62
done