283924 - Move ValidateComment out of CGI.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

I think that it will go to Bugzilla::Bug, because it seems to belong there.

Comment 1

[Max Kanat-Alexander]

Attachment: Simple Move

Another very easy, very short move.

Comment 2

[Frédéric Buclin]

Comment on attachment 175702 [details] [diff] [review]
Simple Move

Software error of the form:
Undefined subroutine &main::ValidateComment called at
/var/www/html/cvsbugzilla/process_bug.cgi line 116.

Appears everywhere ValidateComment() is called.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

OK, I fixed it. I also got rid of the "magic number." I didn't put the constant
in Bugzilla::Constants because no other script or module could have a
conceiveable need to use that constant.

Comment 4

[Frédéric Buclin]

Comment on attachment 175857 [details] [diff] [review]
v2

r=LpSolit

Comment 5

[Max Kanat-Alexander]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.232; previous revision: 1.231
done
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.73; previous revision: 1.72
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.62; previous revision: 1.61
done