Closed Bug 283949 Opened 16 years ago Closed 8 months ago
Overlaying the content pane in the new preferences dialog makes the pane unusable
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050226 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050226 Firefox/1.0+ Installing an extension that overlays the content pane in the new preferences dialog causes Firefox to crash when the content pane is selected. Reproducible: Always Steps to Reproduce: 1. Install extension that overlays the content pane. 2. Restart Firefox 3. Open the preferences dialog 4. Select the content pane Actual Results: Firefox crashes Expected Results: The content pane should display with any added features from the overlay. Talkback crash ID TB3977216Q
confirming. It happens when loading the overlay dynamically via loadOverlay: > document.loadOverlay(aPaneElement.src, obs); in preferences.xml. I don't see how it's because of you not caring about notifications as timeless noted in bug 282103 comment 13 :/ nsXULDocument::ResumeWalk [c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp, line 3209] nsXULDocument::EndLoad [c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp, line 742] XULContentSinkImpl::DidBuildModel [c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/content/xul/document/src/nsXULContentSink.cpp, line 407]
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Crash when overlaying the content pane in the new preferences dialog → Crash when overlaying the content pane in the new preferences dialog - in loadOverlay - [@ nsXULDocument::ResumeWalk]
16 years ago
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Confirmed: TB7805865Y *** Talkback ID
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050731 Firefox/1.0+ TBP 22.214.171.124 overlays the Preference dialog in order to change the src attribute of the <prefpane> "paneTabs", without crashing. In between the 20050722 and 20050725 builds, the ability to overlay the Preference dialog was lost. Bonsai doesn't show any obvious checkins that would cause this. Has the crash become WORKSFORME, with this bug merely preventing the dialog from being overlaid using chrome.manifest?
Just checked with the test case and it does still crash. This bug is about overlaying one of the prefpane xul files, overlaying the preferences.xul file always worked fine and still does for me.
email@example.com: could you contact me off-bug and explain how you do it?
Is this fixed now that the fix for bug 293460 landed?
No this is still not resolved. I have updated the test extension so it has a maxversion of 10 for testing.
Attachment #175722 - Attachment is obsolete: true
I just tested this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050825 Firefox/1.0+ and it doesn't crash, as expected. The content pane is inaccessible though.
No longer a crash problem. I would be interested to know why it was decided for this not to block firefox 1.5.
Summary: Crash when overlaying the content pane in the new preferences dialog - in loadOverlay - [@ nsXULDocument::ResumeWalk] → Overlaying the content pane in the new preferences dialog makes the pane unusable
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
(In reply to comment #9) > The content pane is inaccessible though. I am seeing a similar issue that appears to be related. I have an overlay registered to overlay chrome://browser/content/preferences/privacy.xul. privacy.xul is loaded dynamically via document.loadOverlay here: http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/preferences.xml#688 It seems that when you attach an overlay to an overlay that is loaded dynamically, the resulting load is a blank display. Nothing is painted to the screen. If I load chrome://browser/content/preferences/privacy.xul directly from the url bar, the overlay is correctly loaded and the overlaid document is also correctly displayed. If I unregister the added overlay document, privacy.xul is again correctly loaded and displayed in the prefs pane. I briefly looked over the code in nsXULDocument.cpp and can see my overlaid document being inserted in ::AddChromeOverlays().
I don't see this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre ID:20090417044042 can someone verify if fixed in other platforms as well?
Necropost: fixed @ latest versions
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.