283954 - GetBugLink should use bug state classes described in /skins

Status: RESOLVED INVALID

(Bugzilla :: User Interface, defect)

Description

[Toms Baugis]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050125 Firefox/1.0
Build Identifier: 

Currently GetBugLink just uses 2 styles - italics for UNCONFIRMED and bz_closed
class for FIXED, RESOLVED and VERIFIED bugs.

Instead it should use bug state classes described in /skins.

Reproducible: Always

Steps to Reproduce:
Define bz_VERIFIED class to distinct between resolved-fixed and resolved-verified.
Look in bug dependencies, for resolved-verified bugs.

Actual Results:  
All resolved bugs appear the same

Expected Results:  
Resolved-verified bugs should appear differently, as described in global.css

Comment 1

[Toms Baugis]

Attachment: Add classes to bug spans in GetBugLink

Comment 2

[Toms Baugis]

Comment on attachment 175729 [details] [diff] [review]
Add classes to bug spans in GetBugLink

since myk is owner of UI, i'm asking him for review

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 175729 [details] [diff] [review]
Add classes to bug spans in GetBugLink

Mmm, good fix.	Just one minor problem and a documentation suggestion.

>+            my $pre = '<span class="bz_' . $bug_state . '>';

'>' => '">'


>+.bz_FIXED    { text-decoration: line-through; }
>+.bz_VERIFIED { text-decoration: line-through; }
>+.bz_CLOSED   { text-decoration: line-through; }
>+.bz_closed   { text-decoration: line-through; }

It would be good to note here that bz_closed means the union of closed states
rather than being a synonym for bz_CLOSED.

Comment 4

[Toms Baugis]

that's a great idea!

i noticed myself, that applying patch just solves class problem, when you are in
show_bug.cgi. The showdependency tree uses another way of applying styles
(template filter). and i am not quite sure, how to solve it best.

myk - could you please help on this?

Comment 5

[Toms Baugis]

cleaning up bugzilla - this bug is totally outdated.