283973 - Charts broken: DBD::mysql::st execute failed: Unknown column '$datefrom' in 'field list'

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Teemu Mannermaa (:wicked)]

New Charts are not working on the tip today. Adding &debug=1 produces following
error in the error log:

chart.cgi: DBD::mysql::st execute failed: Unknown column '$datefrom' in 'field
list' [for Statement "SELECT TO_DAYS(series_date) -
TO_DAYS(FROM_UNIXTIME($datefrom)), series_value FROM series_data WHERE series_id
= ? AND series_date >= FROM_UNIXTIME(1103925600) AND series_date <=
FROM_UNIXTIME(1109455200)"] at Bugzilla/Chart.pm line 254

In bug 280499 this line was changed from 
  "  TO_DAYS(FROM_UNIXTIME($datefrom)), " .                       
to
  $dbh->sql_to_days('FROM_UNIXTIME($datefrom)') .
7so this looks like a simple variable quoting error..

Comment 1

[Teemu Mannermaa (:wicked)]

Attachment: Fix quotes, V1

This patch seems to do the trick..

Comment 2

[Max Kanat-Alexander]

Comment on attachment 175743 [details] [diff] [review]
Fix quotes, V1

This looks good. I'd rather it were double-quotes instead of an append, but
hey.

Comment 3

[Teemu Mannermaa (:wicked)]

Attachment: Fix using using double-quotes, V2

Oh yeah, this looks much better. And it still fixes charting. :)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 175764 [details] [diff] [review]
Fix using using double-quotes, V2

Hooray. :-)

Comment 5

[Shane H. W. Travis]

Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.6; previous revision: 1.5
done

Comment 6

[Gervase Markham [:gerv]]

Presumably this was fallout from the cross-db work?

Gerv

Comment 7

[Max Kanat-Alexander]

Yeah.