Closed
Bug 284034
Opened 20 years ago
Closed 20 years ago
nsReadableUtils ToNew* methods crash on OOM
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
References
()
Details
(Keywords: crash)
Attachments
(1 file)
|
3.44 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
The methods in nsReadableUtils that allocate memory (ToNew*) don't check that
the allocation succeeded. As far as I can tell, they would all crash. The
Append methods might behave similarly, but the allocation is hidden inside other
methods.
Shouldn't the ToNew* methods just return nsnull?
|
||
Updated•20 years ago
|
Summary: nsReadableUitls ToNew* methods crash on OOM → nsReadableUtils ToNew* methods crash on OOM
|
||
Comment 1•20 years ago
|
||
yeah, sounds fine to me. patches welcome :)
|
Assignee | |
Comment 2•20 years ago
|
||
Assignee: string → ajschult
Status: NEW → ASSIGNED
Attachment #175893 -
Flags: superreview?(darin)
Attachment #175893 -
Flags: review?(darin)
|
|
||
Updated•20 years ago
|
Attachment #175893 -
Flags: superreview?(darin)
Attachment #175893 -
Flags: superreview+
Attachment #175893 -
Flags: review?(darin)
Attachment #175893 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
fixed
Severity: critical → normal
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•20 years ago
|
Severity: normal → critical
|
||
Updated•4 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•