284083 - crash [@ nsDBFolderInfo::GetTransferInfo :970 ]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Bastiaan Jacques]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050226
Build Identifier: 

Crashing line:

m_mdbRow->GetCount(m_mdb->GetEnv(), &numCells);

So m_mdbRow is NULL.. we can either add a check before this line, or see if we
can find a nicer solution.

Reproducible: Always

Steps to Reproduce:
This appears to occur at tb startup. (it seems to be a win32 bug, I cannot
reproduce myself)



talkback Incident ID: 3999976 and many others

Comment 1

[Bastiaan Jacques]

Attachment: add NULL checks

Try 1: NULL checks

Comment 2

[Bastiaan Jacques]

Looks like this might be a dupe of bug 74491 ..

Comment 3

[timeless]

not a dupe, just the same codepath and a different problem.

Comment 4

[David :Bienvenu]

I recreated this by corrupting a db by hand...a null check will prevent the
crash, but things won't work very well, so a better fix is needed, I think.

Comment 5

[Bastiaan Jacques]

Are you taking this on, David? I could work up a new patch if you're not.

Comment 6

[David :Bienvenu]

sorry, yes, I'm working on it. I believe it's related to another crash I'm
investigating.

Comment 7

[David :Bienvenu]

Can you reproduce this at will?

Comment 8

[Bastiaan Jacques]

No, I cannot reproduce it at all.

Comment 9

[David :Bienvenu]

Attachment: proposed fix

this detects the error in finding the meta row for the db folder info, and
returns an error. This error is propagated, and the db will be regenerated.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 186395 [details] [diff] [review]
proposed fix

a=sspitzer for the crasher fix.

Comment 11

[David :Bienvenu]

Attachment: fix for another instance of this

I managed to cause this crash by creating a .msf file with just a comment line,
so it's non-empty, but still mal-formed. I don't know if occurs in the wild,
but better safe than sorry.

Comment 12

[David :Bienvenu]

second fix checked in.