Closed
Bug 284096
Opened 19 years ago
Closed 19 years ago
Useless Cancel button in "View Saved Passwords"
Categories
(Firefox :: Settings UI, defect, P2)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: me, Assigned: Gavin)
Details
(Keywords: useless-UI, Whiteboard: [good first bug])
Attachments
(1 file)
|
1.24 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The View Saved Passwords dialog in Tools->Options->Privacy->Passwords has both a Cancel and a Close button, however pressing Cancel does not undo any changes made in that dialog. It misleads the user into thinking they can undo any changes they make, however all changes to stored passwords and excluded domains are instantaneous, even on Windows.
|
||
Updated•19 years ago
|
Keywords: useless-UI
|
||
Comment 1•19 years ago
|
||
http://lxr.mozilla.org/mozilla/source/toolkit/components/passwordmgr/resources/content/passwordManager.xul#47 'dlgbuttons' should be named 'buttons' and it will work correctly p.s. it's not only only on Win98 ;-)
|
||
Comment 2•19 years ago
|
||
comment 1 has the fix, someone attach a patch? :)
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Keywords: helpwanted
OS: Windows 98 → All
Hardware: PC → All
Whiteboard: [good first bug]
|
Assignee | |
Comment 3•19 years ago
|
||
as you wish!
|
|
||
Updated•19 years ago
|
Attachment #178092 -
Flags: review?(mconnor) → review+
|
||
Updated•19 years ago
|
Severity: minor → normal
Keywords: helpwanted
Whiteboard: [good first bug] → [good first bug][needs checkin]
Target Milestone: --- → Firefox1.1
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P2
Whiteboard: [good first bug][needs checkin] → [good first bug][checkin needed]
|
|
||
Comment 4•19 years ago
|
||
Checking in components/passwordmgr/resources/content/passwordManager.xul; /cvsroot/mozilla/toolkit/components/passwordmgr/resources/content/passwordManager.xul,v <-- passwordManager.xul new revision: 1.8; previous revision: 1.7 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][checkin needed] → [good first bug]
|
|
Assignee | |
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 5•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in
before you can comment on or make changes to this bug.
Description
•