284108 - $(destdir) should be uppercase on the last line of browser/app/Makefile.in

Status: RESOLVED DUPLICATE of bug 255958

(Firefox Build System :: General, defect)

Description

[Michael Haverkamp]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041122 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041122 Firefox/1.0

"make install" fails if "prefix" is not writeable and $DESTDIR is set.

Reproducible: Always

Steps to Reproduce:
# Do all steps as an unpriviledged user

1.tar xjf firefox-1.0.1-source.tar.bz2
2.cd mozilla
3.cat > .mozconfig <<EOF
. \$topsrcdir/browser/config/mozconfig
 
ac_add_options --prefix=/usr/local/firefox-1.0.1
ac_add_options --disable-debug
ac_add_options --enable-optimize
ac_add_options --enable-xft
ac_add_options --enable-default-toolkit=gtk2
ac_add_options --disable-installer
EOF

4.MOZILLA_OFFICIAL=1 make -f client.mk build
5.DESTDIR=~/firefox-dist-1.0.1 make install

Actual Results:  
/home/mikeh/mozilla/config/nsinstall -t firefox
/home/mikeh/firefox-dist-1.0.1/usr/local/firefox-1.0.1/bin
/home/mikeh/mozilla/config/nsinstall -t -m 644 ../../dist/branding/mozicon50.xpm
../../dist/branding/mozicon16.xpm ../../dist/branding/document.png 
/home/mikeh/firefox-dist-1.0.1/usr/local/firefox-1.0.1/lib/firefox-1.0.1/icons
/home/mikeh/mozilla/config/nsinstall -t -m 644 ../../dist/branding/default.xpm
/home/mikeh/firefox-dist-1.0.1/usr/local/firefox-1.0.1/lib/firefox-1.0.1/icons
/home/mikeh/mozilla/config/nsinstall -t -m 644 profile/prefs.js
/usr/local/firefox-1.0.1/bin/defaults/profile
/home/mikeh/mozilla/config/nsinstall: cannot make directory
/usr/local/firefox-1.0.1: Read-only file system
make[2]: *** [install] Error 1
make[2]: Leaving directory `/home/u60123/mozilla/browser/app'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/u60123/mozilla/browser'
make: *** [install] Error 2

Expected Results:  
Firefox should have been installed under
/home/mikeh/firefox-dist-1.0.1/usr/local/firefox-1.0.1

The problem seem to originate from the last line (323) of
browser/app/Makefile.in (from firefox 1.0.1 source).  On that line, there is a
reference to $(destdir) that should actually be $(DESTDIR).

Comment 1

[Michael Haverkamp]

Attachment: This patch seems to fix the problem.

Comment 2

[Michael Haverkamp]

Comment on attachment 175829 [details] [diff] [review]
This patch seems to fix the problem.

diff -ru ../mozilla.orig/browser/app/Makefile.in ./browser/app/Makefile.in
--- ../mozilla.orig/browser/app/Makefile.in	2004-11-06 18:33:34.000000000
-0600
+++ ./browser/app/Makefile.in	2005-02-28 10:38:22.317886430 -0600
@@ -320,4 +320,4 @@
	$(INSTALL) $^ $(DIST)/bin/defaults/profile

 install:: $(srcdir)/profile/prefs.js
-	$(SYSINSTALL) $(IFLAGS1) $^ $(destdir)$(bindir)/defaults/profile
+	$(SYSINSTALL) $(IFLAGS1) $^ $(DESTDIR)$(bindir)/defaults/profile

Comment 3

[Michael Haverkamp]

Attachment: The patch seems to fix the problem.

Sorry, that last patch was reversed.  This one should be correct.

Comment 4

[cls]

*** This bug has been marked as a duplicate of 255958 ***