284126 - Quick search icon is no longer showing up in the quick search bar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

This regression had to have happened sometime very recently. 

The quick search drop down list (and the associated icon) are not showing up for
the address book, contacts panel and main mail 3 pane quick search bars.

Comment 1

[Scott MacGregor]

this regression happened between 02/23/2005 (works) and 02/25/2005 (fails)

Comment 2

[Scott MacGregor]

This regression was caused by Bug #282735. Backing out that patch makes the
quick search button for Thunderbird's quick search boxes come back again .

Comment 3

[Boris Zbarsky [:bzbarsky]]

Scott, what's the XBL binding involved?  Also, is there any UI in Seamonkey
mailnews that uses the same widgets?  I don't have a Thunderbird build on hand...

Comment 4

[Scott MacGregor]

no there is no seamonkey UI that uses this.

the XBL binding is: 

http://lxr.mozilla.org/mozilla/source/mail/base/content/search.xml

I'm guessing I need a name space on the children tag.

Comment 5

[Boris Zbarsky [:bzbarsky]]

That's correct.  In the id="searchBarDropMarker" binding, we have:

132     <content
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" 
133                  xmlns:xbl="http://www.mozilla.org/xbl" popup="_child">
134       <children/>

So that's a <xul:children>, which shouldn't do anything special.

Not only that, this is a <xul:content>.  That shouldn't do anything either (I've
filed bug 284342 on the fact that it does).  May I ask why there is a xmlns
attribute on that <content> at all?  And why the xmlns:xbl attribute is there? 
It looks to me like both should be removed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to that effect

Scott, does this make things happy?

Comment 7

[Scott MacGregor]

Comment on attachment 175972 [details] [diff] [review]
Patch to that effect

yup that did it. I just checked this in. Thanks for the patch and fix!