"edit" link shows up on confirmation page for deleting a Field Value

RESOLVED FIXED in Bugzilla 2.20

Status

()

P2
minor
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: cedric.caron, Assigned: bugzilla-mozilla)

Tracking

2.19.2
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
When deleting a field value a link is displayed in the confirmation page to 
edit the deleted value !!!

This is very confusing.

Comment 1

14 years ago
mkanat, could you fix this bug please?
Severity: normal → major
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.20
Hahahaha. OK, that's a simple template change. I'll get to it.
Assignee: administration → mkanat
Severity: major → normal
Priority: -- → P1
Summary: invalid fonction proposed after field value delete → "edit" link shows up on confirmation page for deleting a Field Value

Updated

14 years ago
Severity: normal → minor
Priority: P1 → P2
(Assignee)

Comment 3

14 years ago
Created attachment 178788 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 28 March 2005

template/en/default/admin/fieldvalues/footer.html.tmpl has as interface
no_edit_link to disable the edit link. The actual code uses
no_edit_milestone_link.

template/en/default/admin/fieldvalues/deleted.html.tmpl and edit.html.tmpl both
 use no_edit_link.

Patch changes:
  footer.html.tmpl to use no_edit_link
  confirm-delete.html.tmpl to pass no_edit_link = 1
Attachment #178788 - Flags: review?(mkanat)
Comment on attachment 178788 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 28 March 2005

Yeah. On inspection, that looks correct.
Attachment #178788 - Flags: review?(mkanat) → review+

Updated

14 years ago
Assignee: mkanat → bugzilla-mozilla
Flags: approval?

Updated

14 years ago
Status: NEW → ASSIGNED
Flags: approval? → approval+

Comment 5

14 years ago
Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/fieldvalues/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.