284151 - "edit" link shows up on confirmation page for deleting a Field Value

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P2)

Description

[Cédric Caron]

When deleting a field value a link is displayed in the confirmation page to 
edit the deleted value !!!

This is very confusing.

Comment 1

[Frédéric Buclin]

mkanat, could you fix this bug please?

Comment 2

[Max Kanat-Alexander]

Hahahaha. OK, that's a simple template change. I'll get to it.

Comment 3

[Olav Vitters]

Attachment: Patch v1 against Bugzilla HEAD 28 March 2005

template/en/default/admin/fieldvalues/footer.html.tmpl has as interface
no_edit_link to disable the edit link. The actual code uses
no_edit_milestone_link.

template/en/default/admin/fieldvalues/deleted.html.tmpl and edit.html.tmpl both
 use no_edit_link.

Patch changes:
  footer.html.tmpl to use no_edit_link
  confirm-delete.html.tmpl to pass no_edit_link = 1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 178788 [details] [diff] [review]
Patch v1 against Bugzilla HEAD 28 March 2005

Yeah. On inspection, that looks correct.

Comment 5

[Frédéric Buclin]

Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/fieldvalues/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.2; previous revision: 1.1
done