Closed
Bug 284169
Opened 20 years ago
Closed 20 years ago
get rid of WARNING's in console generated by GetTypeForControl
Categories
(Core Graveyard :: XForms, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aaronr, Assigned: aaronr)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
allan
:
review+
|
Details | Diff | Splinter Review |
GetTypeForControl should gracefully handle conditions where control isn't bound to instance data and not issue warnings in debug mode.
removed from GetTypeForControl the NS_ENSURE_TRUE(boundNode, NS_ERROR_FAILURE) and instead simply return NS_ERROR_FAILURE if no boundNode. No need for the console output since it is perfectly valid for a control not to have bound instance data.
Attachment #175867 -
Flags: review?(allan)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 175867 [details] [diff] [review] first attempt r=me
Attachment #175867 -
Flags: review?(allan) → review+
|
||
Comment 3•20 years ago
|
||
r=me too, if needed.
|
||
Comment 4•20 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•