284185 - Incorrect parameter in the "attachment_already_obsolete" error message

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

The "attachment_already_obsolete" error message in code-error.html.tmpl uses
"attachid" for the attachment ID while "attach_id" is used in attachment.cgi.
Consequently, the attachment ID is not displayed when obsoleting an already
obsolete attachment.

Comment 1

[Frédéric Buclin]

Attachment: trivial fix, v1

replace attachid by attach_id in code-error.html.tmpl.

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 175883 [details] [diff] [review]
trivial fix, v1

r=wurblzap by inspection.

Comment 3

[Marc Schumann [:Wurblzap]]

In 2.18, the relevant parts of attachment.cgi and code-error.html.tmpl are
identical.

Comment 4

[Shane H. W. Travis]

2.18:
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-
error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.39.2.4; previous revision: 1.39.2.3
done

Tip:
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-
error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.46; previous revision: 1.45
done