284251 - nsMacEventHandler sends 0 to the keypress event for some keys (e.g. space)

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Mac, defect, P2)

Description

[Asaf Romano (gone)]

While working on some mac-menu bugs/enhancements in XP code, i found out that
nsMacEventHandler sends 0 as the keycode for many keys. Apparently, this only
applies to the keypress event (and not to keydoewn / keyup events).

Comment 1

[Asaf Romano (gone)]

Attachment: proposed patch

While this does fix this issue, I have to say, ftang's code is unreadable (the
hard tabs don't help either) and proably worths rewrite. However, I don't think
we should ever sent 0 as the keycode...

Comment 2

[Simon Fraser [no longer active]]

It seems like the original change (in bug 41305) deliberately set either the
charCode or the keyCode, but not both. Was there a reason for that? We should
make sure we match what Windows does.

Comment 3

[Boris Zbarsky [:bzbarsky]]

For keypress, charCode should be set for "character" keys, and keyCode should be
set for all other keys.  Changing this willy-nilly would break a lot of JS
content out there, I suspect...

Comment 4

[Asaf Romano (gone)]

Comment on attachment 175932 [details] [diff] [review]
proposed patch

this one is wrong

Comment 5

[Asaf Romano (gone)]

As i understand it now, for charcaters |keycode=0; charcode=ascii value|; This
works fine. -> invalid.