Open Bug 284319 Opened 20 years ago Updated 2 years ago

move allowFrames from docshell to document

Categories

(Core :: Layout, defect)

x86
Windows XP
defect

Tracking

()

People

(Reporter: bernd_mozilla, Unassigned)

References

Details

in bug 240129 the allowSubframes will change so that we avoid that mutable style
dance in the frame constructor. However the property should then sit rather at
the document.

bz	jst: current proposal is as follows
	bz	jst: 1) The boolean only affects HTML frames (so not XUL, eg)
	-->|	v0id (wikked@dialup-4.245.143.108.Dial1.Stamford1.Level3.net) has joined
#developers
	bz	jst: 2) The boolean is gotten from the docshell by the prescontext
	bz	jst: I was thinking that it'd make sense to replace #2 with "docshell sets
the boolean on the document, so prescontexts have access to it"
	bz	jst: along with "document notifies prescontexts if the boolean changes"
	bz	jst: thoughts?
	bz	jst: put another way, given a DOM-created document, when we have the pref
set, do we want to honor the pref?
	bz	jst: and not load the subframes?
	bz	jst: note there is no docshell in sight there...
	jst	bz: hmm, good question. I think I'd say we do honor the pref, we could just
check it at document creation time or something... or do we just check the pref
at each load?
	-->|	jesus_X (jesus_x@204.95.67.22) has joined #developers
	bz	I'd say check the pref at document creation
	bz	And set up a listener...
	jst	sure
	bz	(and fix content policy to get the data off the document instead of the
docshell)
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.