Closed
Bug 284320
Opened 19 years ago
Closed 16 years ago
[FIX]implement a better storage/retrieval method for nsSubDocumentFrames content parent
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
46.32 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
this is a followup from bug 240129 >+ the nsSubDocumentFrame needs to know about its content parent during ::Init. >+ // there is no reasonable way to get the value there. >+ // so we store it as a frame property. Can you file a bug on this? cc me and roc. I think this should be easy to fix. (done)
Assignee | ||
Comment 1•19 years ago
|
||
Hmm... so I actually read the comment in nsSubDocumentFrame::Init this time. I thought we could just force the view in CreateViewForFrame, but we're actually needing the view before CreateViewForFrame has been called.... We also can't create the view till after the superclass Init() has been called. So perhaps what we have now is the simplest way to do it after all. :(
Assignee | ||
Comment 2•16 years ago
|
||
The good news is that we don't need this anymore.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Summary: implement a better storage/retrieval method for nsSubDocumentFrames content parent → [FIX]implement a better storage/retrieval method for nsSubDocumentFrames content parent
Assignee | ||
Comment 3•16 years ago
|
||
Attachment #355635 -
Flags: superreview?(roc)
Attachment #355635 -
Flags: review?(roc)
Attachment #355635 -
Flags: superreview?(roc)
Attachment #355635 -
Flags: superreview+
Attachment #355635 -
Flags: review?(roc)
Attachment #355635 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/a67b8808aadd
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•