SHGetMalloc API call is deprecated (in SpecialSystemDirectory.cpp)

RESOLVED FIXED in mozilla1.9alpha1

Status

()

RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: David.R.Gardiner, Assigned: David.R.Gardiner)

Tracking

Trunk
mozilla1.9alpha1
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

14 years ago
According to the MSDN documentation
(http://msdn.microsoft.com/library/en-us/shellcc/platform/shell/reference/functions/shgetmalloc.asp)

"This function should no longer be used. Use the CoTaskMemFree and
CoTaskMemAlloc functions in its place"

This appears to be used in XPCOM in the following files:

/xpcom/io/SpecialSystemDirectory.cpp, line 197 -- if
(!SUCCEEDED(SHGetMalloc(&pMalloc)))
/xpcom/obsolete/nsSpecialSystemDirectory.cpp, line 216 -- if
(!SUCCEEDED(SHGetMalloc(&pMalloc)))
(Assignee)

Comment 1

14 years ago
Created attachment 176125 [details] [diff] [review]
Use CoTaskMemAlloc and CoTaskMemFree
Assignee: dougt → david.gardiner
Status: NEW → ASSIGNED
Attachment #176125 - Flags: review?(dougt)

Comment 2

14 years ago
Comment on attachment 176125 [details] [diff] [review]
Use CoTaskMemAlloc and CoTaskMemFree

r=dougt

Thanks for the patch.  Do you need someone to check this in?
Attachment #176125 - Flags: review?(dougt) → review+
(Assignee)

Comment 3

14 years ago
Yes please!

-dave
(Assignee)

Updated

14 years ago
Attachment #176125 - Flags: superreview?(brendan)
QA Contact: xpcom

Comment 4

12 years ago
Did this ever get checked in?
Whiteboard: [checkin needed]
This was fixed for the patch for bug 359808.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Attachment #176125 - Attachment is obsolete: true
Attachment #176125 - Flags: superreview?(brendan)
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.