Closed
Bug 284324
Opened 20 years ago
Closed 19 years ago
SHGetMalloc API call is deprecated (in SpecialSystemDirectory.cpp)
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: David.R.Gardiner, Assigned: David.R.Gardiner)
References
Details
Attachments
(1 obsolete file)
According to the MSDN documentation
(http://msdn.microsoft.com/library/en-us/shellcc/platform/shell/reference/functions/shgetmalloc.asp)
"This function should no longer be used. Use the CoTaskMemFree and
CoTaskMemAlloc functions in its place"
This appears to be used in XPCOM in the following files:
/xpcom/io/SpecialSystemDirectory.cpp, line 197 -- if
(!SUCCEEDED(SHGetMalloc(&pMalloc)))
/xpcom/obsolete/nsSpecialSystemDirectory.cpp, line 216 -- if
(!SUCCEEDED(SHGetMalloc(&pMalloc)))
|
Assignee | |
Comment 1•20 years ago
|
||
|
||
Comment 2•20 years ago
|
||
Comment on attachment 176125 [details] [diff] [review]
Use CoTaskMemAlloc and CoTaskMemFree
r=dougt
Thanks for the patch. Do you need someone to check this in?
Attachment #176125 -
Flags: review?(dougt) → review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Yes please!
-dave
|
|
Assignee | |
Updated•20 years ago
|
Attachment #176125 -
Flags: superreview?(brendan)
|
||
Updated•19 years ago
|
QA Contact: xpcom
|
||
Comment 4•19 years ago
|
||
Did this ever get checked in?
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 5•19 years ago
|
||
This was fixed for the patch for bug 359808.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
|
|
||
Updated•19 years ago
|
Attachment #176125 -
Attachment is obsolete: true
Attachment #176125 -
Flags: superreview?(brendan)
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•