284329 - SHGetMalloc API call is deprecated (in setup.c)

Status: RESOLVED WORKSFORME

(Firefox :: Installer, defect)

Description

[David Gardiner]

According to the MSDN documentation
(http://msdn.microsoft.com/library/en-us/shellcc/platform/shell/reference/functions/shgetmalloc.asp)

"This function should no longer be used. Use the CoTaskMemFree and
CoTaskMemAlloc functions in its place"

This is used in:

/toolkit/mozapps/installer/windows/wizard/setup/dialogs.c, line 653 -- if
(SUCCEEDED(SHGetMalloc(&shellMalloc))) {

Though I note that current the code is #ifdef'd not to compile, and a comment
indicates that a memory leak results.

Hope I've picked the right component (sorry if i chose wrong)

-dave

Comment 1

[David Gardiner]

Attachment: Use CoTaskMemFree to release memory

Comment 2

[David Gardiner]

Comment on attachment 176127 [details] [diff] [review]
Use CoTaskMemFree to release memory

Happy to have someone check this in.

-dave

Comment 3

[Benjamin Smedberg]

Reassigning to Neil for seamonkey management.

Comment 4

[David Gardiner]

Attachment: Use CoTaskMemFree to release memory

Updated against latest version

Comment 5

[[e-mail]]

Comment on attachment 184546 [details] [diff] [review]
Use CoTaskMemFree to release memory

Sorry, I don't know installers.

Comment 6

[Phil Ringnalda (:philor)]

With the change to the NSIS installer, it's gone.