Closed Bug 284352 Opened 20 years ago Closed 20 years ago

Break Bugzilla::DB code/docs into sections

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.19.2
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file, 1 obsolete file)

I'm going to be adding a lot of stuff to the Bugzilla::DB docs, so the sections
need to be clearer.

I have a patch for this, coming up.
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
Attachment #175978 - Flags: review?(travis)
Comment on attachment 175978 [details] [diff] [review]
Slight cleanup for Bugzilla::DB docs

+These methods are actually implemented in Bugzilla::DB, and only need
 -- remove 'actually'

+Thse methods return information about data in the database.
 ^^^^^ typo

+=head2 Schema Info Methods
-- don't abbrev. if you don't have to. (Same thing on the next line)

+These methods deal with starting and stopping transactions in the database.
Grammar: These methods deal with THE starting and stopping OF transactions in
the database.

+These methods deal with starting and stopping transactions in the database.

Missing the "=over 4" after this line.

Fix these for r+.
Attachment #175978 - Flags: review?(travis) → review-
Summary: Slight cleanup for Bugzilla::DB docs → Break Bugzilla::DB code/docs into sections
I slightly expanded the scope of the bug, to also add comments above each
"section" in the code, so we can keep things organized there, too.
Attachment #175978 - Attachment is obsolete: true
Attachment #176223 - Flags: review?(travis)
Comment on attachment 176223 [details] [diff] [review]
Add "sections" to Bugzilla::DB

+These methods return info about the current Bugzilla database schema.

Everywhere else, you spell out 'information' in full, as per my last review
except on this one line. This is more than a nit, I suppose, as I'd really like
it to be consistent, but I trust you to fix it yourself on checkin.

r+ by inspection.
Attachment #176223 - Flags: review?(travis) → review+
Flags: approval?
Flags: approval? → approval+
Ohh, arrgh, I forgot to fix that checkin change, though. Ahh, well. It wasn't
hugely important.

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.26; previous revision: 1.25
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: