284362 - FTP/HTTP: hostname passed to OnStatus should be UTF-8

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

see url. this should probably be UTF-8, given IDN...

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, mHost is retrieved by GetAsciiHost... still, it seems better to pass the
host as the real name rather than punycode.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... HTTP also passes the ASCII host, afaict...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch (ftp + http)

Comment 4

[Darin Fisher]

Comment on attachment 177571 [details] [diff] [review]
patch (ftp + http)

It probably makes sense to get rid of nsFTPChannel::mHost altogether.

r+sr=darin either way

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

now without nsFTPChannel::mHost

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in netwerk/protocol/ftp/src/nsFTPChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.cpp,v  <--  nsFTPChannel.cpp
new revision: 1.145; previous revision: 1.144
done
Checking in netwerk/protocol/ftp/src/nsFTPChannel.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.h,v  <--  nsFTPChannel.h
new revision: 1.83; previous revision: 1.82
done
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <-- 
nsHttpChannel.cpp
new revision: 1.244; previous revision: 1.243
done

Comment 7

[Darin Fisher]

looks good