Closed Bug 284362 Opened 20 years ago Closed 19 years ago

FTP/HTTP: hostname passed to OnStatus should be UTF-8

Categories

(Core Graveyard :: Networking: FTP, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: Biesinger, Assigned: Biesinger)

References

()

Details

(Keywords: intl)

Attachments

(1 file, 1 obsolete file)

see url. this should probably be UTF-8, given IDN...
oh, mHost is retrieved by GetAsciiHost... still, it seems better to pass the
host as the real name rather than punycode.
hm... HTTP also passes the ASCII host, afaict...
Attached patch patch (ftp + http) (obsolete) — Splinter Review
Assignee: dougt → cbiesinger
Status: NEW → ASSIGNED
Attachment #177571 - Flags: superreview?(darin)
Attachment #177571 - Flags: review?(darin)
Priority: -- → P1
Summary: FTP treats hostname as ASCII → FTP/HTTP: hostname passed to OnStatus should be UTF-8
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 177571 [details] [diff] [review]
patch (ftp + http)

It probably makes sense to get rid of nsFTPChannel::mHost altogether.

r+sr=darin either way
Attachment #177571 - Flags: superreview?(darin)
Attachment #177571 - Flags: superreview+
Attachment #177571 - Flags: review?(darin)
Attachment #177571 - Flags: review+
Attached patch patch v2Splinter Review
now without nsFTPChannel::mHost
Attachment #177571 - Attachment is obsolete: true
Checking in netwerk/protocol/ftp/src/nsFTPChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.cpp,v  <--  nsFTPChannel.cpp
new revision: 1.145; previous revision: 1.144
done
Checking in netwerk/protocol/ftp/src/nsFTPChannel.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.h,v  <--  nsFTPChannel.h
new revision: 1.83; previous revision: 1.82
done
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <-- 
nsHttpChannel.cpp
new revision: 1.244; previous revision: 1.243
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
looks good
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: