FTP/HTTP: hostname passed to OnStatus should be UTF-8

RESOLVED FIXED in mozilla1.8beta2

Status

()

Core
Networking: FTP
P1
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

({intl})

Trunk
mozilla1.8beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

see url. this should probably be UTF-8, given IDN...
oh, mHost is retrieved by GetAsciiHost... still, it seems better to pass the
host as the real name rather than punycode.
hm... HTTP also passes the ASCII host, afaict...
Created attachment 177571 [details] [diff] [review]
patch (ftp + http)
Assignee: dougt → cbiesinger
Status: NEW → ASSIGNED
Attachment #177571 - Flags: superreview?(darin)
Attachment #177571 - Flags: review?(darin)
Priority: -- → P1
Summary: FTP treats hostname as ASCII → FTP/HTTP: hostname passed to OnStatus should be UTF-8
Target Milestone: --- → mozilla1.8beta2

Comment 4

14 years ago
Comment on attachment 177571 [details] [diff] [review]
patch (ftp + http)

It probably makes sense to get rid of nsFTPChannel::mHost altogether.

r+sr=darin either way
Attachment #177571 - Flags: superreview?(darin)
Attachment #177571 - Flags: superreview+
Attachment #177571 - Flags: review?(darin)
Attachment #177571 - Flags: review+
Created attachment 177621 [details] [diff] [review]
patch v2

now without nsFTPChannel::mHost
Attachment #177571 - Attachment is obsolete: true
Checking in netwerk/protocol/ftp/src/nsFTPChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.cpp,v  <--  nsFTPChannel.cpp
new revision: 1.145; previous revision: 1.144
done
Checking in netwerk/protocol/ftp/src/nsFTPChannel.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.h,v  <--  nsFTPChannel.h
new revision: 1.83; previous revision: 1.82
done
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <-- 
nsHttpChannel.cpp
new revision: 1.244; previous revision: 1.243
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 7

14 years ago
looks good
You need to log in before you can comment on or make changes to this bug.