284364 - Plugins don't work in window where midas has been enabled.

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Johnny Stenback (:jst)]

When enabling midas in a window, the editor turns off plugins, as it probably
should. The problem is that it never turns them on again when leaving the page.
Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Turn on plugins when we're done editing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 175986 [details] [diff] [review]
Turn on plugins when we're done editing.

>Index: editor/composer/src/nsEditingSession.cpp
>+  // Disable plugins in this document:
>+  rv = docShell->GetAllowPlugins(&tmp);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+
>+  mPluginsEnabled = tmp;
>+
>+  rv = docShell->SetAllowJavascript(PR_FALSE);
>+  NS_ENSURE_SUCCESS(rv, rv);

s/Javascript/Plugins/ here, no?

r+sr=bzbarsky with that.

Comment 3

[Johnny Stenback (:jst)]

Duh, yeah. Fix checked in.