284405 - document Cmd+. (Command-Period) shortcut introduced by bug 238954

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

Comment 1

[Asaf Romano (gone)]

Note: On mac, both Command+. and ESC work for Stop (the former is the visible one).

Comment 2

[Jeff Walden (gone starting June 8)]

This is trivial and easily doable for 1.1.  However, if by some incredibly odd
twist of fate we weren't able to fix this quickly enough it's not nearly
important enough to block 1.1.  Steffen, feel like picking this up?  It's
probably a five-minute fix (assuming you can find Mano on IRC for a once-over to
make sure we're correctly documenting a platform neither of us uses).

Comment 3

[Steffen Wilberg]

Attachment: patch

Yeah, I thought about doing that these days :)

So we have on Mac:
  Cmd+.
  Esc

On the other platforms:
  Esc

Mano, can you please confirm that it does indeed look like that on Mac?

Comment 4

[Asaf Romano (gone)]

Comment on attachment 176988 [details] [diff] [review]
patch

looks good.

Comment 5

[Jeff Walden (gone starting June 8)]

Comment on attachment 176988 [details] [diff] [review]
patch

The intent of my first comment was to say that Mano's once-over for correctness
would be sufficient for review purposes, but in my attempt to be concise I
apparently didn't communicate that.  :-)

r=[e-mail].

Comment 6

[Steffen Wilberg]

(In reply to comment #5)
;-)

Checking in mozilla/browser/components/help/locale/en-US/shortcuts.xhtml;
/cvsroot/mozilla/browser/components/help/locale/en-US/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.24; previous revision: 1.23
done