284418 - crash if run application without 'file' protocol specifying [@ nsDocShell::DoURILoad ]

Status: RESOLVED DUPLICATE of bug 282644

(Core :: DOM: Navigation, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.5) Gecko/20041108 Firefox/1.0 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.5) Gecko/20041108 Firefox/1.0 (ax)

When I try execute 'mozilla.exe c:\MyProjects\test.xul' then mozilla is crashed.

Reproducible: Always

Steps to Reproduce:

Comment 1

[alexander :surkov (:asurkov)]

It's valid in build Mozilla 1.8b (Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8b) Gecko/20050217)

Comment 2

[Adam Hauner]

Alexander Surkov: Could you provide Talkback incident ID?

Comment 3

[alexander :surkov (:asurkov)]

TB4073686E

Comment 4

[Adam Hauner]

-> Emb / Docshell

TB4073686E:
nsDocShell::DoURILoad 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/docshell/base/nsDocShell.cpp,
line 5755]
nsDocShell::InternalLoad 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/docshell/base/nsDocShell.cpp,
line 5660]
nsDocShell::LoadURI 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/docshell/base/nsDocShell.cpp,
line 765]
nsWindowWatcher::OpenWindowJS 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 778]
nsWindowWatcher::OpenWindow 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 465]
OpenWindow 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 552]
OpenWindow 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 489]
LaunchApplicationWithArgs 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 671]
DoCommandLines 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 786]
main1 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1272]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1811]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1839]
KERNEL32.DLL + 0x87f5 (0x793a87f5)

Comment 5

[Boris Zbarsky [:bzbarsky]]

So, looking at nsDocShell line 5755 in the relevant revision we have:

5755 bzbarsky        1.500             nsresult rv2 =
mContentListener->OnStartURIOpen(aURI, &abort);
5756                                   if (NS_SUCCEEDED(rv2) && abort) {

Note that the very next day (Feb 18), I checked in a patch for bug 282644, which
fixed a similar Camino crash at this very line.  So please retest with a current
trunk build?

That said, this looks like a bug in the Firefox command-line stuff too -- why
are we getting into docshell with an unknown-protocol URI?

Comment 6

[alexander :surkov (:asurkov)]

I can't reproduce this bug with a Mozilla 1.8b (Mozilla/5.0 (Windows; U; Windows
NT 5.0; en-US; rv:1.8b) Gecko/20050217) build.

When I try to run xul application as before but with command line argument
'-chrome' (i.e 'mozilla.exe -chrome c:\MyProjects\test.xul') then mozilla is
crashed. I don't know is this bug the same thing or something else.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, the firefox thing was with 1.0....  Just marking duplicate, then.

*** This bug has been marked as a duplicate of 282644 ***