284560 - Can't add English [en] to the language list

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Oliver Saier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050302 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050302 Firefox/1.0+

1. Go to options>advanced>general>edit languages...
2. Remove English [en]
3. Try to add it back

Reproducible: Always

Actual Results:  
Clicking the Add button has no visible effect


It can still be added by editing the intl.accept_languages pref.

Comment 1

[Ger Teunis]

I confirm this, can't seem to add english[en] as well.

Comment 2

[Peter van der Woude [:Peter6]]

->NEW

Comment 3

[Anbo Motohiko]

Attachment: patch

String 'en' matches 'en-us', so we cannot add language 'en'.

This patch also fixes:
Bug 284088 - Removing the first language in list doesn't work properly

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 176140 [details] [diff] [review]
patch

Looks OK, but fix these nits:

>+        languagesArray.push( item.id );

No whitespace around item.id.

>+    var string = languagesArray.join(',');

These files standardize on " for quotes, not '

... then r=[e-mail]

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

I fixed the nits and checked this in. 

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change