284574 - Empty strings from C++ XPCOM are converted to null, not to JSString object

Status: RESOLVED INVALID

(Core :: XPConnect, defect)

Description

[Dmitry Egorenkov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

XPConnect, namely code in js/src/xpconnect/src/xpcconvert.cpp, should convert
empty strings (with zero length or null pointers) that it gets from C++ XPCOM
objects to JSString objects. Now it converts them to null, so in JavaScript I
get 'null' instead of empty strings.



Reproducible: Always

Steps to Reproduce:

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

null pointers are null pointers. why should they become empty strings instead of
null?

(I thought zero-length strings already are converted to "" in JS, are they not?
http://lxr.mozilla.org/seamonkey/source/js/src/xpconnect/src/xpcconvert.cpp#351
looks like they are)

Comment 2

[Dmitry Egorenkov]

Agree about null pointers. I was much more concerned about zero-length strings
and they work perfectly – it was my bug.

I’m ashamed.

Comment 3

[David Bradley]

No need to be ashamed, you realized your mistake and corrected it.