284599 - Use of REGEXP search is not consistent wrt case sensitivity

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Tomas Kopal]

We use regular expression search on couple of places in Search.pm. Most of the
occurences has LOWER function called on the column, supposedly to perform case
insesitive search, but the parameter is passed in as it is, so we'll never match
expression with upper case letters. As MySQL regexp is (as of 3.23.4) case
insensitive, it does not matter, but it does matter for other DBs.
If we really want case insensitive regexp, then we can remove the LOWER call and
we should also change Pg implementation to use case insensitive regexp.

Comment 1

[Tomas Kopal]

Attachment: V1

Regexp is now case-insensitive on both supported DBs.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 181038 [details] [diff] [review]
V1

Yes, this looks correct.

HOWEVER, for the future: both MySQL and PostgreSQL do not deal well with
multi-byte strings in regexes, particularly not for case-insensitive things.

PostgreSQL does not correctly "lowercase" things outside of ISO-8859-1.

For MySQL, the regex operator is not multi-byte safe at all.

These are things we can deal with at another time, though.

I suspect that the indexing of these things doesn't matter one way or another,
as the regex operators probably don't use indexes anyhow.

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.51; previous revision: 1.50
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.95; previous revision: 1.94
done
Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.8; previous revision: 1.7
done