284629 - Combine Param(enable_mail_sending) with Param(maildeliverymethod)

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Shane H. W. Travis]

As Jake said in bug 178370 comment 13, I implemented the fix to that bug 
poorly. A better way is to add a choice 'none' to maildeliverymethod.

While I'm modifying this parameter, I'm also going to properly space the words 
out with underscores (as per bug 155628) to mail_delivery_method.

Patch to follow.

Comment 1

[Shane H. W. Travis]

Attachment: Code patch for tip

Comment 2

[Shane H. W. Travis]

Attachment: Code patch for tip, take 2

Updated due to bitrot after checkin of bug 280778

Comment 3

[Jacob Steenhagen]

Comment on attachment 176593 [details] [diff] [review]
Code patch for tip, take 2

Looks good, even the comments I never made were addressed by the bitrot fix :)

Comment 4

[Shane H. W. Travis]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.363; previous revision: 1.362
done
Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.153; previous revision: 1.152
done
Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.36; previous revision: 1.35
done

Comment 5

[Frédéric Buclin]

For the record, the documentation has already been updated in bug 313469.

Comment 6

[Frédéric Buclin]

Attachment: documentation patch, v1

maildeliverymethod -> mail_delivery_method. I don't think I need review for such a change. ;)