284632 - Add notification (authentication) support in webdav

Status: RESOLVED INCOMPLETE

(Core Graveyard :: WebDAV, defect)

Description

[Stelian Pop]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050224 Firefox/1.0.1 Fedora/1.0.1-1.3.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050224 Firefox/1.0.1 Fedora/1.0.1-1.3.1

currently the webdav extension code does not do authentification at all.

the attached patch adds a notificationCallbacks attribute to nsIWebDAVResource.
This callback gets propagated to the channel and is called when an
authentification is necessary.

An application can use this callback to call a nsIAuthPrompt implementation...

Reproducible: Always

Comment 1

[Stelian Pop]

Attachment: patch implementing the feature

Comment 2

[Mike Shaver (:shaver emeritus)]

Hrm, I'm not sure that the notification callbacks are really part of the
resource.   I'd like to put locks on the resource, because pretty much any
operation on a given resource will want to use any present locks, but different
operations on a given resource may well want different notification targets.

I also _loathe_ nsIInterfaceRequestor, but I guess that's the interface necko
wants here.  Hmph.

Comment 3

[Mike Shaver (:shaver emeritus)]

So I still don't like having it on the resource interface.  What do people think
about

/**
 * Return an interface pointer that will use the provided notificationCallbacks
 * for all appropriate network operations.
 */
nsIWebDAVService getAuthenticatingWrapper(in nsIInterfaceRequestor
notificationCallbacks);

on nsIWebDAVService?

Comment 4

[Stelian Pop]

This is ok for me.

Comment 5

[Mike Shaver (:shaver emeritus)]

Mass abdication.