284636 - Typo in Website Certified by an Unknown Authority alert

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[PTRourke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050104 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050104 Firefox/1.0+

Paragraph above "Examine Certificate" button on "Website Certified by an Unknown
Authority" alert has repeated word "to".

Reproducible: Always

Steps to Reproduce:
1. Navigate via https protocol to a site with a self-signed certificate.
2. The "Website Certified by an Unknown Authority" alert should appear.
3. Read the paragraph before the "Examine Certificate" button. The fourth and
fifth words in the second (and last) sentence of that paragraph are repetitive.

Actual Results:  
Paragraph above "Examine Certificate" button reads:

"Before accepting this certificate, you should examine this site's
certificate carefully. Are you willing to to accept this certificate
for the purpose of identifying the Web site www.xyz.com?"

TO TO ACCEPT 

Expected Results:  
Paragraph above "Examine Certificate" button should read:

"Before accepting this certificate, you should examine this site's
certificate carefully. Are you willing to accept this certificate
for the purpose of identifying the Web site www.xyz.com?"

TO ACCEPT

Comment 1

[Stefan [:stefanh]]

Hmm, this is in
http://lxr.mozilla.org/seamonkey/source/security/manager/pki/resources/locale/en-US/newserver.properties#43

The text must have been copied from
http://lxr.mozilla.org/seamonkey/source/security/manager/ssl/public/nsIBadCertListener.idl#85
for almost 2,5 years ago, since the error is there as well...

Comment 2

[u88484]

Attachment: patch

patch for mozilla code.
http://lxr.mozilla.org/mozilla/source/security/manager/ssl/public/nsIBadCertListener.idl


For some reason I can't download for seakmonkey and security code so I can
update this file there.
http://lxr.mozilla.org/security/source/security/manager/ssl/public/nsIBadCertListener.idl

http://lxr.mozilla.org/seamonkey/source/security/manager/ssl/public/nsIBadCertListener.idl

Comment 3

[Stefan [:stefanh]]

What about this:

http://lxr.mozilla.org/seamonkey/source/security/manager/locales/en-US/chrome/pippki/newserver.properties#43

As for review, not sure but it might be better to try kai.

Comment 4

[u88484]

Comment on attachment 194064 [details] [diff] [review]
patch 


stefan h: for somereason i can only checkout mozilla/ and not from seakmonkey/
security/ mailnews/ etc... that howcome i didnt make a patch for the other
places this typo shows up

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 307068 has been marked as a duplicate of this bug. ***

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch (checked in)

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 194064 [details] [diff] [review]
patch 

r=kaie

Comment 8

[u88484]

Comment on attachment 194064 [details] [diff] [review]
patch 

no risk

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 194064 [details] [diff] [review]
patch 

This is superceded by my later patch.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Fixes landed by Chris Thomas at 2005-09-18 17:05 PDT.

Thanks to Kurt for the original patch!

Comment 11

[Jo Hermans]

*** Bug 317592 has been marked as a duplicate of this bug. ***

Comment 12

[Kai Engert (:KaiE:)]

Comment on attachment 194873 [details] [diff] [review]
Patch (checked in)

Actually, not appropriate for 1.8 branch, as it changes an IDL file.