284808 - Slight display glitch on homepage selector in GTK2 builds

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Markus Lindström]

There seems to be a small graphical glitch in GTK2 builds, in the Home Page
section of the General tab in the new Preferences window.

For some reason, the text field is surrounded by an awkward white box, which
looks pretty ugly. Oddly enough, all other text fields in the new Prefwindow
seem to be doing fine, like the history persistance selector.

I'll attach a screenshot showcasing the bug.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050304 Firefox/1.0+

Comment 1

[Markus Lindström]

Attachment: Screenshot showing the glitch

Notice the odd white box around the Home Page selector text field. It seems to
be the one and only text field suffering from this bug.

Comment 2

[Hanspeter Niederstrasser]

Attachment: gets rid of ring around the collar

Comment 3

[Hanspeter Niederstrasser]

Comment on attachment 191805 [details] [diff] [review]
gets rid of ring around the collar

changing review request to mconnor as suggested on #developers

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 191805 [details] [diff] [review]
gets rid of ring around the collar

there's another bug on this somewhere, and I rolled the fix from that bug for
this in the patch for bug 309140

Comment 5

[Hanspeter Niederstrasser]

This is now fixed in branch at least (didn't test trunk but should be also) from
checkin to bug 309140.

Comment 6

[Markus Lindström]

*** Bug 306434 has been marked as a duplicate of this bug. ***

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

this is a trivial fix that is very desired by gtk users...

Comment 8

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #7)

As stated in comment #5, a patch for this has been checked into branch and trunk
with bug 309140. I'm now downloading the current nightly to verify.

Comment 9

[Marek Stępień [:marcoos, inactive]]

Yep, it's ok now.
Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8b5) Gecko/20050930 Firefox/1.4

Resolving WFM.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

sorry. My fault.

Comment 11

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change