Closed Bug 284811 Opened 15 years ago Closed 15 years ago

Remove %FORM from enter_bug.cgi classification code

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.19.2
enhancement
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: wicked, Assigned: wicked)

References

Details

Attachments

(1 file)

Since bug 238862 landed, new classification code using %FORM variables was added
to enter_bug.cgi (in bug 224208). These should be removed too..

78:      $::FORM{'classification'}=(keys %::classdesc)[0];
81:   if (!defined $::FORM{'classification'}) {
99:           $vars->{'format'} = $::FORM{'format'};
108:       $::FORM{'classification'} = (keys %classdesc)[0];
109:       $::MFORM{'classification'} = [$::FORM{'classification'}];
115:            if (IsInClassification($::FORM{'classification'},$p) ||
116:                $::FORM{'classification'} eq "__all") {
131:        elsif ($::FORM{'classification'} eq "__all") {
134:            $classifications{$::FORM{'classification'}} =
135:                $::classifications{$::FORM{'classification'}};
Assignee: nobody → wicked
Status: NEW → ASSIGNED
Attachment #176369 - Flags: review?
Attachment #176369 - Flags: review? → review?(jouni)
Attachment #176369 - Flags: review?(jouni) → review?(LpSolit)
Comment on attachment 176369 [details] [diff] [review]
Remove remaining enter_bug.cgi FORMs, V1

r=LpSolit

I cannot test it as much as I would like due to bug 286311. But the problem
reported there is not related to this patch. ;)
Attachment #176369 - Flags: review?(LpSolit) → review+
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
Flags: approval? → approval+
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.110; previous revision: 1.109
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.